Repository navigation
Combine hot reload + hot restart tests to speed up test runs- #6168 - #6170
Merged
Merged
Conversation
DanTup
added
the
is testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## merge-debug-tests-2 #6170 +/- ##
=======================================================
+ Coverage 70.77% 70.82% +0.05%
=======================================================
Files 170 170
Lines 13158 13158
Branches 2649 2649
=======================================================
+ Hits 9312 9319 +7
+ Misses 3325 3319 -6
+ Partials 521 520 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Spawning a real Flutter app is very slow, so combe these to have a single launch. See #6165
DanTup
force-pushed
the
merge-debug-tests-3
branch
from
September 5, 2026 14:54
ae8dc27 to
648dce1
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward test consolidation with only a minor naming/diagnostics nit that doesn’t affect correctness.
Pull request overview
This PR speeds up the Flutter “test device” debug test suite by combining hot reload and hot restart assertions into a single test, avoiding an extra (slow) Flutter app launch per run.
Changes:
- Merged the hot restart test into the existing hot reload test flow to reuse a single debugger/app session.
- Updated the test name to reflect coverage of both hot reload and hot restart behaviors.
File summaries
| File | Description |
|---|---|
| src/test/flutter_debug/flutter_run.test_device.test.ts | Combines hot reload and hot restart coverage into one test to reduce repeated Flutter app launches and speed up CI. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DanTup
added a commit
that referenced
this pull request
Sep 5, 2026
DanTup
added a commit
that referenced
this pull request
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawning a real Flutter app is very slow, so combe these to have a single launch.
See #6165