Repository navigation
Don't run flutter test tests both by line + by name if they are not affected by location/invocation mode - #6171
Conversation
DanTup
added
the
is testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## merge-debug-tests-3 #6171 +/- ##
=======================================================
- Coverage 70.82% 70.80% -0.03%
=======================================================
Files 170 170
Lines 13158 13158
Branches 2649 2649
=======================================================
- Hits 9319 9316 -3
- Misses 3319 3321 +2
- Partials 520 521 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… affected by location/invocation mode Many of these tests run the whole suite and therefore are not affected by the `testInvocationMode` setting. This moves them outside the loop so they run only once instead of twice. See #6165
ba7b57a to
795a9ee
Compare
There was a problem hiding this comment.
🟡 Changes recommended
One moved test’s waitFor predicate is effectively always true for startedSessions, which can allow a false-positive pass and should be corrected before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR speeds up the flutter_test_debug test suite by avoiding running tests twice (by name + by line) when the behavior under test isn’t affected by dart.testInvocationMode, while keeping the invocation-mode-sensitive tests inside the loop.
Changes:
- Moved “whole-suite” Flutter test debugger tests outside the
testInvocationModeloop so they run only once. - Converted some slow integration-style tests into faster configuration-resolution assertions using
getLaunchConfiguration(...). - Added use of
flutterTestDeviceIdfor device-aware launch config assertions.
File summaries
| File | Description |
|---|---|
| src/test/flutter_test_debug/debug/flutter_test.test.ts | Refactors the test structure to reduce duplicate runs across invocation modes and replaces some slow runs with launch-config assertions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Many of these tests run the whole suite and therefore are not affected by the
testInvocationModesetting. This moves them outside the loop so they run only once instead of twice.See #6165