Repository navigation
Remove unsupported commands from Unix modules - #1701
Merged
Dongbo Wang (daxian-dbw) merged 8 commits intoAug 10, 2016
Merged
Conversation
| PowerShellVersion="3.0" | ||
| NestedModules="Microsoft.PowerShell.Commands.Management.dll" | ||
| HelpInfoURI = 'http://go.microsoft.com/fwlink/?linkid=390785' | ||
| AliasesToExport = @("gin", "gtz", "stz") |
There was a problem hiding this comment.
gin -> get-computerinformation
gtz -> get-timezone
stz -> set-timezone
they need to be removed if the corresponding cmdlets are not available.
Member
Author
There was a problem hiding this comment.
Ah haha, thank you!
Since we need different versions for Windows and Unix.
Unmodified so we can track changes.
Member
Author
There was a problem hiding this comment.
$Command, my bad
ConvertFrom-SddlString and Unblock-File are Windows-specific cmdlets with no equivalent on Unix. squash! Remove Unblock-File from Unix
Since we need different versions for Windows and Unix.
Unmodified so we can track changes.
These are not currently implemented and so should not show up as available. The *-Computer cmdlets are already not compiled for Unix (and so not available), so let's not declare them in the manifest. The Get-ComputerInfo cmdlet does not work on Unix and so should not be made available. Test-Connection depends on an unavailable WMI provider. Get/Set-TimeZone are not yet ported.
There are no longer module declarations that are identical between Core PowerShell on Windows and on Unix.
The "unavailable cmdlets" section was removed pending a comprehensive list compiled from the module declarations.
Member
|
LGTM. |
6 of 11 tasks
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
Remove unsupported commands from Unix modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1207.
With the work that sergei (@vors) did, we support platform-specific modules. After consulting with Steve Lee (@SteveL-MSFT), Francisco Gamino (@Francisco-Gamino), Dongbo Wang (@daxian-dbw), and Mike Richmond (@mirichmo), we believe this is the right approach (at least for now) to improve user experience of PowerShell on Unix.
See commits for changes.
/cc Travis Plunk (@TravisEz13)