Skip to content

Remove unsupported commands from Unix modules - #1701

Merged
Dongbo Wang (daxian-dbw) merged 8 commits into
PowerShell:masterfrom
andyleejordan:unix-modules
Aug 10, 2016
Merged

Dongbo Wang (daxian-dbw) merged 8 commits into
PowerShell:masterfrom
andyleejordan:unix-modules

Conversation

@andyleejordan

Copy link
Copy Markdown
Member

Resolves #1207.

With the work that sergei (@vors) did, we support platform-specific modules. After consulting with Steve Lee (@SteveL-MSFT), Francisco Gamino (@Francisco-Gamino), Dongbo Wang (@daxian-dbw), and Mike Richmond (@mirichmo), we believe this is the right approach (at least for now) to improve user experience of PowerShell on Unix.

See commits for changes.

/cc Travis Plunk (@TravisEz13)

PowerShellVersion="3.0"
NestedModules="Microsoft.PowerShell.Commands.Management.dll"
HelpInfoURI = 'http://go.microsoft.com/fwlink/?linkid=390785'
AliasesToExport = @("gin", "gtz", "stz")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gin -> get-computerinformation
gtz -> get-timezone
stz -> set-timezone
they need to be removed if the corresponding cmdlets are not available.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah haha, thank you!

Since we need different versions for Windows and Unix.
Unmodified so we can track changes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$Command, my bad

ConvertFrom-SddlString and Unblock-File are Windows-specific cmdlets
with no equivalent on Unix.

squash! Remove Unblock-File from Unix
Since we need different versions for Windows and Unix.
Unmodified so we can track changes.
These are not currently implemented and so should not show up as
available.

The *-Computer cmdlets are already not compiled for Unix (and so not
available), so let's not declare them in the manifest.

The Get-ComputerInfo cmdlet does not work on Unix and so should not be
made available.

Test-Connection depends on an unavailable WMI provider.

Get/Set-TimeZone are not yet ported.
There are no longer module declarations that are identical between Core
PowerShell on Windows and on Unix.
The "unavailable cmdlets" section was removed pending a comprehensive
list compiled from the module declarations.
@daxian-dbw

Copy link
Copy Markdown
Member

LGTM.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 2aa5c07 into PowerShell:master Aug 10, 2016
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the unix-modules branch August 10, 2016 05:28
@TravisEz13 Travis Plunk (TravisEz13) added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Waiting on Author labels May 27, 2020
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Remove unsupported commands from Unix modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept WG-Maintainers-Build specific to affecting the build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unblock-file on linux failes with module could not be found

3 participants