Repository navigation
feat(sess)!: stabilize attach identity and endpoint contract - #1764
Merged
eitsupi merged 32 commits intoSep 26, 2026
Merged
Conversation
eitsupi
changed the title
eitsupi
marked this pull request as draft
September 23, 2026 17:42
eitsupi
marked this pull request as ready for review
September 23, 2026 17:45
eitsupi
marked this pull request as draft
September 23, 2026 17:54
eitsupi
marked this pull request as ready for review
September 23, 2026 18:02
eitsupi
marked this pull request as draft
September 23, 2026 18:03
eitsupi
marked this pull request as ready for review
September 23, 2026 18:29
eitsupi
marked this pull request as draft
September 23, 2026 18:36
eitsupi
marked this pull request as draft
September 25, 2026 23:54
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Thanks for supporting the downstream applications. This might be another bug for native R terminals. When VS Code is reloaded, R process survives, but Here is a small demo. R.restore.mp4 |
eitsupi
marked this pull request as ready for review
September 26, 2026 02:36
eitsupi
marked this pull request as draft
September 26, 2026 02:43
Member
Author
|
@Fred-Wu I believe I've fixed the bug you pointed out, so could you please check it again? |
eitsupi
marked this pull request as ready for review
September 26, 2026 03:46
Contributor
|
Connections are now correctly restored automatically after VS Code reload. But Remove or fix in the next release? |
Fred-Wu
approved these changes
Sep 26, 2026
Member
Author
Thanks for pointing that out! |
This was referenced Sep 26, 2026
This was referenced Oct 6, 2026
eitsupi
added a commit
that referenced
this pull request
Oct 7, 2026
…1837) Fixes #1836. #1764 introduced the public session API with pseudoterminal downstream clients in mind. #1805 made Workspace actions execute in their owning session, but terminal dispatch only resolves native PID associations, leaving extension-owned pseudoterminals without an execution target. Add backward-compatible `session.activate(sessionId, { terminal })` to explicitly bind a terminal. Interactive execution retains priority; terminal execution uses the session's current explicit or native association. Unassociated background sessions still reject terminal execution. Execution, readiness and terminal selection share a registry with at most one terminal per session and one session per terminal. Explicit binding replaces either endpoint's previous association, so a superseded native terminal cannot return as a fallback when the explicit terminal closes. Live explicit bindings take priority over native attach. Close and connection replacement invalidate associations; queued sends validate the exact association, and delayed native discovery cannot overwrite intervening ownership changes or a newer connection. Reconnect refreshes the selected session's connection even after same-session reselection, while preserving a newer selection of a different session; old Workspace nodes still reject execution. **Downstream follow-up:** vscode-R-console needs to pass its VS Code Terminal when activating a sess session, and repeat registration after reconnecting. Older vscode-R implementations ignore the extra argument, so downstream can retain compatibility with their existing activation API. No vscode-R-console sources or sess wire protocol are changed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On master, sess identity and discovery depend on local PIDs and
~/.vscode-R/sessions/<PID>.json. Reloading VS Code leaves surviving R processes disconnected, and restoring one terminal can prevent manual recovery of another. This PR establishes the session contract before the first stable 3.x release (#1763).session_id. Use socket ownership for cleanup so a late close cannot remove a replacement connection; defer workspace and plot notifications until task callbacks return, with generation guards across disconnects.sess::connect(endpoint = ...),SESS_ENDPOINT, andSESS_DISCOVERY_FILE. Store managed discovery files and attach scripts in extension storage, without making its directory layout part of the contract.versionandendpoint, ignores unknown fields, and permits optional backend fields such asjgdSocketwithout a version bump.Breaking pre-release changes: replace
pipe_path,SESS_PIPE, thepipediscovery field, and the PID-based home-directory fallback. Transport remains local Unix-domain sockets / Windows named pipes.