You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I realise how unhelpful this comment right here is, but TIFF decoding across the board can be really tricky to get right - there are loads of compression formats, and even fairly respected tools (from MS / Atalasoft) get it wrong even with 1-bit images. I think some archiving formats even require special licensing to implement correctly. It might be worth identifying a small subset of formats to support!
@kierenj It's certainly not an unhelpful comment. Tiff would be hard and I'm sorely tempted to let someone else figure it out and concentrate on what we have already. I'm just dreading the day someone tells me that the library is useless without it. There's always someone!
@ChrisVanDijk Good effort but have you benchmarked that codec? The Bitmiracle jpeg codec was about 10x slower and used 190MB more to process a small test image compared to our codec. I imagine the Tiff one will be the same. I'd be careful using it.
@Andy-Wilkinson you have been playing around with Tiff haven't you with your own stuff? I wonder if we can use some of it?
@ChrisVanDijk understandable. Tiff is a complex format so I'm pushing it to the backburner until I can get everything else out of the way... Not looking forward to tackling it!
@ChrisVanDijk@JimBobSquarePants One big "advantage" of these naive C ports is that its really not that hard to make the first steps towards speeding & cleaning them up.
Someone with time & a profiler could check it, and estimate the efforts needed reuse/refactor elements of that code.
@JimBobSquarePants I've got the basics of reading the Tiff format itself working from my own project (I started here since many Camera Raw files are mutant Tiff files). As you mention, there are a number of compression formats, but the key ones probably aren't too much trouble. The one issue with my existing codebase is that it was a bit of an experiment in a more functional style of C#, rather than how you might structure it normally.
All that said, I know a fair amount about the Tiff format now, so probably would be able to make a quick start on a true ImageSharp Tiff codec pretty easily (and share a bit of the code where I can). Would you be interested in me picking up this issue and giving it a start? (especially since you guys seem to be busy enough with the existing codec perf 😄)
Reacted by Anton Firszov, James Jackson-South and Makla
Activity
JimBobSquarePants commentedon Oct 30, 2016
From @kierenj on September 7, 2016 20:27
I realise how unhelpful this comment right here is, but TIFF decoding across the board can be really tricky to get right - there are loads of compression formats, and even fairly respected tools (from MS / Atalasoft) get it wrong even with 1-bit images. I think some archiving formats even require special licensing to implement correctly. It might be worth identifying a small subset of formats to support!
JimBobSquarePants commentedon Oct 30, 2016
@kierenj It's certainly not an unhelpful comment. Tiff would be hard and I'm sorely tempted to let someone else figure it out and concentrate on what we have already. I'm just dreading the day someone tells me that the library is useless without it. There's always someone!
ChrisVanDijk commentedon Feb 22, 2017
I needed to import Tiff files so I created a temporary Tiff encoder and decoder based on LibTiff.Net.
JimBobSquarePants commentedon Feb 22, 2017
@ChrisVanDijk Good effort but have you benchmarked that codec? The Bitmiracle jpeg codec was about 10x slower and used 190MB more to process a small test image compared to our codec. I imagine the Tiff one will be the same. I'd be careful using it.
@Andy-Wilkinson you have been playing around with Tiff haven't you with your own stuff? I wonder if we can use some of it?
ChrisVanDijk commentedon Feb 22, 2017
@JimBobSquarePants The code and performance is bad, but I really needed the ability to open Tiff files. It's a temporary solution until a better one.
JimBobSquarePants commentedon Feb 22, 2017
@ChrisVanDijk understandable. Tiff is a complex format so I'm pushing it to the backburner until I can get everything else out of the way... Not looking forward to tackling it!
antonfirsov commentedon Feb 22, 2017
@ChrisVanDijk @JimBobSquarePants One big "advantage" of these naive C ports is that its really not that hard to make the first steps towards speeding & cleaning them up.
Someone with time & a profiler could check it, and estimate the efforts needed reuse/refactor elements of that code.
Andy-Wilkinson commentedon Feb 22, 2017
@JimBobSquarePants I've got the basics of reading the Tiff format itself working from my own project (I started here since many Camera Raw files are mutant Tiff files). As you mention, there are a number of compression formats, but the key ones probably aren't too much trouble. The one issue with my existing codebase is that it was a bit of an experiment in a more functional style of C#, rather than how you might structure it normally.
All that said, I know a fair amount about the Tiff format now, so probably would be able to make a quick start on a true ImageSharp Tiff codec pretty easily (and share a bit of the code where I can). Would you be interested in me picking up this issue and giving it a start? (especially since you guys seem to be busy enough with the existing codec perf 😄)
JimBobSquarePants commentedon Feb 22, 2017
@antonfirsov I've found with those ports though there's about a million lines more code than I'd like to read nested in there.
@Andy-Wilkinson That would be absolutely brilliant if you could! 💯
68 remaining items
#12 Tiff specific fixes for lzw
Merge pull request #1457 from IldarKhayrutdinov/tiff-format
Merge pull request #1496 from IldarKhayrutdinov/tiff-format-benchmarks
Merge pull request #1494 from IldarKhayrutdinov/tiff-format
Merge pull request #1537 from IldarKhayrutdinov/tiff-format
brianpopow commentedon May 25, 2021
I am happy to announce that we have now support for decoding and encoding Tiff images with #1553 merged to the master branch.
You can try it out with our nightly build from our myget feed
For now this feature has to be activated manually by the user, which can be done in several different ways:
JimBobSquarePants commentedon May 25, 2021
@brianpopow let’s make that automatic. 🙂
brianpopow commentedon May 26, 2021
With #1634 merged, the Tiff format is now added to the default Configuration.
cocosip commentedon Dec 31, 2021
Hi, i try to read a tiff image, but it throw
Tiled images are not supported.Any plan to support
Construction of image (from tile data)?Thank you!
JimBobSquarePants commentedon Jan 4, 2022
No plans currently. That would require community support to implement.