Repository navigation
Documentation tests are no longer run by default #5695
Description
While trying to get pytest 3.x to work (#5688), I noticed that some of the rst files do not pass even with current master (i.e., the built-in pytest). The problem seems to be that currently none of the doctests get run. E.g., a recent travis log [1] shows only test files, while older ones also show regular python files with doctests as well as the rst files [2]. So, somehow they are getting omitted... (or am I missing something totally dumb?!?!?)
[1] recent log, no doctests: https://travis-ci.org/astropy/astropy/jobs/191377361
[2] older log, includes doctests: https://travis-ci.org/astropy/astropy/jobs/158108205
Activity
pllim commentedon Jan 13, 2017
I would say that merging #5688 would automatically fix this.
mhvk commentedon Jan 13, 2017
Agreed, but I'd still like to understand why the tests were no longer run. Also, ideally we'd ensure this doesn't recur. So cc @bsipocz and @astrofrog.
pllim commentedon Jan 13, 2017
When did we last update the bundled pytest? (ANSWER: 9c7ae60 on Jan 9, 2016)
Did it coincide with doctest disappearing? (ANSWER: No, since the log given above was dated Sep 2016)
Back to square one. 😦
pllim commentedon Jan 13, 2017
So... going through all the master builds on Travis, the last time doctest was run was in https://travis-ci.org/astropy/astropy/jobs/190178481 as part of https://travis-ci.org/astropy/astropy/builds/190178474, right before #5678 was merged. I restarted one of the jobs in https://travis-ci.org/astropy/astropy/builds/190406525. If my suspicion is correct, this one will not have doctest.
pllim commentedon Jan 13, 2017
Just as I suspected... https://travis-ci.org/astropy/astropy/jobs/190406534 does not have doctest for the first time. I think the mistake here is introducing pytest 3.x feature in #5678, which is not ready for the transition yet. It was necessary for testing with pytest 3.x locally (at the hack day) but it should not be propagated to master until bundled version is removed. I propose changing
[tool:pytest]back to[pytest]in current master and re-introduce the change in #5688. What do you think?mhvk commentedon Jan 13, 2017
@pllim - nice tracking down! I agree we need to undo the change in
setup.cfg.