Repository navigation
[EXP] changed yield to parameterize - #5678
Merged
Merged
Conversation
mhvk
reviewed
Jan 8, 2017
| n_map_files = 28 | ||
|
|
||
| if len(hdr_map_file_list) != n_map_files: | ||
| assert False, ( |
Contributor
There was a problem hiding this comment.
The construct was already in the file, but is truly odd, so might as well change:
assert len(hdr_map_file_list) == n_map_files, (<text as is>)
(and again below)
Contributor
|
Nice refactoring; looks good to me modulo the one comment (which is really just to refactor a little further). |
Contributor
- changed assert construction - fixed variable name bug
Contributor
Contributor
|
p.s. the travis error is real: |
fixes for test_wcs. Yields removed to get rid of deprecation warnings in pytest3 and be compatible with pytest4
Contributor
|
I think this all looks OK now, so will merge... |
|
@mhvk - thanks for merging this! However, I noticed the following issues with this pull request:
Would it be possible to fix these? Thanks! If you believe the above to be incorrect (which I - @astrobot - very much doubt) you can ping @astrofrog |
mhvk
added
Bug
no-changelog-entry-needed
and removed
Experimental
Work in progress
labels
This was referenced Jan 13, 2017
6 tasks done
bsipocz
pushed a commit
that referenced
this pull request
Feb 14, 2017
Change yield to parameterize in wcs tests for pytest 3.x compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a deprecated warning with pytest3. implemented fix in test_profiling.py but same fix didnt work in test_wcs.py. #hackaas cc @nden @pllim