Repository navigation
Use parametrize instead of yield for tests in units and io.votable - #5682
Merged
Merged
Conversation
kelle
self-requested a review
January 9, 2017 15:06
kelle
reviewed
Jan 9, 2017
kelle
left a comment
kelle
left a comment
Member
There was a problem hiding this comment.
I've never done proper code review before but this looks good to me! I think one other person should look at it though.
Contributor
Author
|
OK, thanks! @pllim - great if you can have a second look; it should be ready. |
Contributor
Author
|
I'm convinced enough by this to go ahead and merge, so that at least our test suite is pytest 3.x compatible. |
This was referenced Jan 9, 2017
pllim
reviewed
Jan 10, 2017
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
If it passes, it's good to me. I was traveling, hence the late comment. I apologize for any inconvenience caused.
Contributor
Author
|
@pllim - no apologies needed - it really is just my impatience (and trying to minimize the number of things "something should be done with"). |
bsipocz
pushed a commit
that referenced
this pull request
Feb 14, 2017
Use parametrize instead of yield for tests in units and io.votable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows on #5678 in ensuring that we do not use
yieldfor running series of tests, but rather usepytest.mark.parametrize, as the former is deprecated in pytest >=3. With #5678 taking care ofwcs, this should remove all usage in astropy.Note: I labelled it as a bug and set the milestone to 1.3.1 since recent versions of astropy should work with pytest >=3.
@kelle - would you be able to have a quick look?