Skip to content

Deprecate analytic_functions subpackage #5780

Description

@pllim

It is not needed anymore after models support Quantity, as Blackbody will be over at models.

Activity

  1. cheekujodhpur commented on Apr 2, 2017

    @cheekujodhpur

    @pllim What is the update on this? Since I can't find Blackbody in models yet.

    I recently needed to use it, so I am interested in adding it if nobody is working on it.

  2. bsipocz commented on Apr 2, 2017

    @bsipocz
    Member

    @cheekujodhpur - Moving blackbody to modeling is a quite complicated task and one that is being worked on.
    When done, it will be released in 2.0 over the summer. The deprecation of analytic_functions will happen in the same release, and will be finally removed in 3.0.
    However 2.0 will be a LTS release, so if you need to use blackbody now, I suggest to go ahead and use analytic_functions.

  3. cheekujodhpur commented on Apr 2, 2017

    @cheekujodhpur

    @bsipocz Is anyone already working on it? I already wrote this .
    I was wondering if it is possible for me to help add it to modeling

  4. bsipocz commented on Apr 2, 2017

    @bsipocz
    Member

    @cheekujodhpur -As I said it's a complicated task, and while I'm not a maintainer of modeling am certain that cross using analytical_functions is not a suitable solution.

    See relevant issues and PRs about it, e.g. #3852 and #4855.

    If you are interested in contributing I suggest to start with issues that are labelled as package-novice.

  5. astrofrog commented on Apr 2, 2017

    @astrofrog
    Member

    The blackbody function stuff is already taken care of in #4855

  6. pllim commented on Apr 3, 2017

    @pllim
    MemberAuthor

    As noted above, blackbody model will be a part of an existing PR that incorporates units in models. As for deprecating analytic_functions, it is on my to-do list when the time is right. I plan to do it in a similar fashion as #5904. So maybe I will just assign to myself.

  7. self-assigned this
    on Apr 3, 2017
  8. added this to the v2.0.0 milestone on Apr 3, 2017
  9. bsipocz commented on Apr 3, 2017

    @bsipocz
    Member

    @pllim - and for the blackbody deprecation, I would argue that we may indeed need to do a "last before release" approach, as affiliates may actually use it while also supporting LTS.

  10. pllim commented on Apr 4, 2017

    @pllim
    MemberAuthor

    Noted. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions