You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@cheekujodhpur - Moving blackbody to modeling is a quite complicated task and one that is being worked on.
When done, it will be released in 2.0 over the summer. The deprecation of analytic_functions will happen in the same release, and will be finally removed in 3.0.
However 2.0 will be a LTS release, so if you need to use blackbody now, I suggest to go ahead and use analytic_functions.
@cheekujodhpur -As I said it's a complicated task, and while I'm not a maintainer of modeling am certain that cross using analytical_functions is not a suitable solution.
See relevant issues and PRs about it, e.g. #3852 and #4855.
If you are interested in contributing I suggest to start with issues that are labelled as package-novice.
As noted above, blackbody model will be a part of an existing PR that incorporates units in models. As for deprecating analytic_functions, it is on my to-do list when the time is right. I plan to do it in a similar fashion as #5904. So maybe I will just assign to myself.
@pllim - and for the blackbody deprecation, I would argue that we may indeed need to do a "last before release" approach, as affiliates may actually use it while also supporting LTS.
Activity
cheekujodhpur commentedon Apr 2, 2017
@pllim What is the update on this? Since I can't find Blackbody in models yet.
I recently needed to use it, so I am interested in adding it if nobody is working on it.
bsipocz commentedon Apr 2, 2017
@cheekujodhpur - Moving blackbody to modeling is a quite complicated task and one that is being worked on.
When done, it will be released in 2.0 over the summer. The deprecation of
analytic_functionswill happen in the same release, and will be finally removed in 3.0.However 2.0 will be a LTS release, so if you need to use blackbody now, I suggest to go ahead and use
analytic_functions.cheekujodhpur commentedon Apr 2, 2017
@bsipocz Is anyone already working on it? I already wrote this .
I was wondering if it is possible for me to help add it to modeling
bsipocz commentedon Apr 2, 2017
@cheekujodhpur -As I said it's a complicated task, and while I'm not a maintainer of modeling am certain that cross using
analytical_functionsis not a suitable solution.See relevant issues and PRs about it, e.g. #3852 and #4855.
If you are interested in contributing I suggest to start with issues that are labelled as
package-novice.astrofrog commentedon Apr 2, 2017
The blackbody function stuff is already taken care of in #4855
pllim commentedon Apr 3, 2017
As noted above, blackbody model will be a part of an existing PR that incorporates units in models. As for deprecating
analytic_functions, it is on my to-do list when the time is right. I plan to do it in a similar fashion as #5904. So maybe I will just assign to myself.bsipocz commentedon Apr 3, 2017
@pllim - and for the blackbody deprecation, I would argue that we may indeed need to do a "last before release" approach, as affiliates may actually use it while also supporting LTS.
pllim commentedon Apr 4, 2017
Noted. Thanks!