Repository navigation
Raise NotImplementedError when parsing with output-only format - #11829
Merged
Merged
Conversation
pllim
approved these changes
Jun 9, 2021
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
Seems uncontroversial to me but I'll leave it open for Ole's review.
Contributor
Author
|
Am merging since it will help get me out of rebase problems in #11830... |
Contributor
Author
|
@olebole - input is still welcome! If you see problems, I'll fix separately... |
Member
|
No problems, however my point was that the message with an unknown input format is confusing: >>> u.Unit('Ω', format='foo')
[…]
ValueError: Unknown format 'foo'. Valid formatter names are: [base, generic, unscaled, cds, console, fits, latex, latex_inline, ogip, unicode, vounit]This error says that |
Contributor
Author
|
Hmm, that is actually fairly tricky, since the unknown format error is raised in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: Really, just resolving over-eager exception catching...
Previously,
Now:
fixes #11828
milestone'd 5.0, since really this is just a change in error type.
cc @olebole, @pllim