Repository navigation
Unit format refactoring - #11830
Merged
Merged
Unit format refactoring#11830
Conversation
5 of 6 tasks
mhvk
force-pushed
the
unit-format-refactoring
branch
from
June 9, 2021 18:50
a500e35 to
135c841
Compare
pllim
approved these changes
Jun 9, 2021
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
I trust the tests but I'll leave this open for Adrian to have a look too. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An old metaclass I happened to come across while doing #11829 - which is just to keep a registry, something for which
__init_subclass__is very well suitable. Partially addresses #7144 (and similar to what @adrn did in #11090).