Skip to content

TST: also test building against Limited API on Windows - #18252

Merged
astrofrog merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/win/limited-api-compat
Jun 13, 2025
Merged

astrofrog merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/win/limited-api-compat

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Follow up to #18236 and #18250, now that I'm seeing Windows-specific issues in #18249

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Cool, so the error we're getting actually has nothing to do with Limited API and is probably present since at least #16918
The fix should probably be backported since it might affect end-users building from source on windows (if any).

@neutrinoceros
neutrinoceros force-pushed the tst/win/limited-api-compat branch from fde7eea to 69c7020 Compare June 10, 2025 13:38
@neutrinoceros neutrinoceros changed the title TST: also test building against Limited API on Windows TST: also test building against Limited API on Windows (⏰ wait for #18253) Jun 10, 2025
@neutrinoceros
neutrinoceros force-pushed the tst/win/limited-api-compat branch from 69c7020 to d05adbc Compare June 10, 2025 13:50
@neutrinoceros neutrinoceros added this to the v7.2.0 milestone Jun 10, 2025
@neutrinoceros
neutrinoceros force-pushed the tst/win/limited-api-compat branch from d05adbc to 1f74e4e Compare June 10, 2025 14:05
@neutrinoceros neutrinoceros removed the Bug label Jun 10, 2025
@neutrinoceros
neutrinoceros force-pushed the tst/win/limited-api-compat branch 2 times, most recently from 0c437fd to 19e9dcc Compare June 10, 2025 14:33
@neutrinoceros
neutrinoceros force-pushed the tst/win/limited-api-compat branch from 19e9dcc to 643334f Compare June 12, 2025 15:44
@neutrinoceros neutrinoceros changed the title TST: also test building against Limited API on Windows (⏰ wait for #18253) TST: also test building against Limited API on Windows Jun 12, 2025
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

The added job now pass so, undrafting !

@neutrinoceros
neutrinoceros marked this pull request as ready for review June 12, 2025 15:48
@pllim
pllim requested a review from astrofrog June 12, 2025 16:01
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

gentle ping @astrofrog

@astrofrog
astrofrog merged commit 03fab96 into astropy:main Jun 13, 2025
@neutrinoceros
neutrinoceros deleted the tst/win/limited-api-compat branch June 13, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants