Repository navigation
Fix for endianness test on Python - #1887
Merged
Merged
Conversation
mdboom
added a commit
that referenced
this pull request
Dec 18, 2013
Fix for endianness test on Python
Member
|
So, certain versions of Numpy really blow up if you provide the byteorder symbol as a byte string? Wow..... |
Contributor
Author
|
It seems to be anything on Python 3. |
Contributor
Author
|
...and the reason this wasn't caught was because it's in an if block that only runs on big endian platforms. It worked at one time, but then broke during the transition from 2to3 to six. |
Member
|
Oy gevaldt |
mdboom
added a commit
that referenced
this pull request
Feb 12, 2014
Fix for endianness test on Python
mdboom
added a commit
that referenced
this pull request
Feb 12, 2014
Fix for endianness test on Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another partial fix for #1849, and a follow-on to #1855.