Repository navigation
Fix issues installing AstroPy with Python 3.x - #23
Conversation
There was a problem hiding this comment.
Not to be pedantic, but shouldn't this still say except ImportError?
There was a problem hiding this comment.
What if the data is not utf-8? Then the comparison with original_data fails. Encoding needs to be the responsibility of the caller. I will submit a pull request to fix this.
Handle the encoding of the file contents in the caller.
|
Are there any other issues that need to be fixed before this can be merged? |
|
I'm getting a bunch of errors in the tests that seem to be due to the OrderedDict tests... these seem to mostly have to do with some changes in sequence behavior and various similar quirks. We probably don't care, though, because we sholdn't be using the backported odict in 3.2 anyway. Perhaps we either check for version >2.6 and just have the tests be no-op if so? Or maybe there's a way to tell py.test to do this... |
|
I was getting some errors both from wcs and odict, but I figured that for now the main issue is to be able to have the package install, then we can try and fix the tests after (I'll ask Tom A. what he thinks re: the failing odict tests since he implemented most of it into astropy). In the mean time, is there any reason not to merge this? (apart from the |
|
I think the content looks fine. py.test has a builtin way to skip tests just like this, though (see http://pytest.org/latest/skipping.html#marking-a-test-function-to-be-skipped) - I'll submit a pull request to your branch implementing that just for the odict stuff. So just hold off for a bit so I can do that and you can have a look. |
|
I've submitted a pull request to this to fix the astropy.wcs tests. |
Fix astropy.wcs tests on Python 3.x
force freezing version to use log and skip odict when builtin in use
|
With the latest commits, AstroPy install correctly on Python 2.6, 2.7, and 3.2, and no tests fail. The odict tests are skipped on 2.7 and 3.2. Ok to merge? |
Fix issues installing AstroPy with Python 3.x
Fix issues installing AstroPy with Python 3.x
Add from_name to SkyCoord
4 participants
The following commits fix the installation issues in Python 3.x while still working in Python 2.6 and 2.7. 22 tests are failing in Python 3.2, but at least the package installs, so maybe we can merge this and then fix the package-specific issues after?