WIP: Python 3.5 support by mdboom · Pull Request #4027 · astropy/astropy

mdboom · 2015-07-31T19:24:38Z

There were two classes of issues:

re.sub now cares about the replacement string looking reasonable in terms of escape characters, and we were doing %Y to \d\d\d\d etc. (and it doesn't like the \d). It turns out that where we were using it, str.replace works just as well.
inspect.getargspec now raises a DeprecationWarning. I made a little wrapper around it that doesn't do that, but long term, we should look at all of the call sites that use it to make sure that the logic makes sense in the face of non-positional-keyword arguments (a Python 3.x feature). My fix here essentially papering that over, which allows our tests to pass since we don't use that Python 3.x feature anywhere, but it could bite us in the future.

Also, this required upgrading pytest to git master. I think we should put this PR on ice until there is a py.test release made that's officially Python 3.5 compatible.

mdboom · 2015-07-31T19:47:21Z

Oh -- and I forgot we're using Conda here. We'll also need to wait until Conda has a Python 3.5 channel (or write a dependency script based on pyenv...)

astrofrog · 2015-08-01T15:52:59Z

@mdboom - for the deprecation warning, could we also not just filter that here?

https://github.com/astropy/astropy/blob/master/astropy/tests/helper.py#L440

We are already doing it for some other warnings.

mdboom · 2015-08-03T13:01:53Z

@astrofrog: This PR adds such a filter. However, it's not sufficient because the (a) warning is emitted on import before the filter even has a chance, and (b) it still spams the user during normal operation (which is different from the other warnings we filter for). Also, in this case it does indicate a real shortcoming in our code -- mainly that some features aren't compatible with keyword-only-arguments, so, long term at least, we should fix all the call sites.

embray · 2015-08-03T15:21:55Z

Regarding getargspec, we already include a backport of inspect.signature. The getargspec wrapper can be done away with, and code that uses inspect.getargspec can instead use from astropy.utils.compat.funcsigs import signature (and related utilities).

mdboom · 2015-08-03T15:46:33Z

Ah -- I didn't know about the backport of signature. That seems like the way to go.

embray · 2015-08-03T15:54:04Z

Yes, it's a much nicer interface. Admittedly, more work to change over to in all the relevant places.

mdboom · 2015-08-06T13:33:11Z

This has been updated to use signature in place of getargspec.

I think we should still wait on py.test here before merging this -- don't know when they plan to release a Python 3.5-compatible version. Maybe after 3.5 is released.

embray · 2015-08-06T14:29:51Z

I just ran py.tests's test suit (from its latest trunk) on Python 3.5b4 and it passed, so presumably their next release will be Python 3.5-compatible if it isn't already.

mdboom · 2015-08-06T14:35:57Z

This PR updates py.test to the latest git master as well (which is why it works at all)... I just think we should wait for a py.test release and not vendor an unreleased version.

mdboom · 2015-09-14T18:50:03Z

I've removed the py.test upgrade from this PR -- this should then pass on Travis for everything but Python 3.5 (if all goes well).

astrofrog · 2015-09-14T19:33:37Z

What about adding 3.5 to the allowed failures for now on Travis, but merge (if it passes otherwise) so that the fixes we know are needed are at least in master?

mdboom · 2015-09-14T19:34:28Z

@astrofrog: I was thinking of something like that. Still working out the last kinks and then will make the appropriate action on Travis.

embray · 2015-09-14T19:50:10Z

Thanks @mdboom for prioritizing this!

embray · 2015-09-14T19:50:45Z

I want to include this in v1.0.5. The backport probably won't be completely clean, but I'll take care of that.

embray · 2015-09-14T19:51:34Z

Once this is ready please also add a note about Python 3.5 support in the changes for 1.0.5.

astrofrog · 2015-09-14T21:41:32Z

You'll need to add this to the allow_failures line below (in addition to here)

Yeah -- I just wanted to test it first, because the failures on 3.5 have been spurious, and I was hoping I could knock them out altogether.

mdboom · 2015-09-14T21:55:46Z

In the end, I've marked Python 3.5 as an allowed failure -- the failures there are nondeterministic, but do seem related to py.test itself and not us.

mdboom · 2015-09-15T13:39:50Z

This seems to be passing now -- though 3.5 is still an "allowed failure". We'll still need py.test to catch up for that one, I think.

mdboom · 2015-09-15T14:54:26Z

py.test 2.7.3 (with Python 3.5 support) was just announced minutes ago. I'm going to test this with that and see how it goes.

py.test 2.7.3 now warns about these things

This is now required in py.test 2.7.3

mdboom · 2015-09-15T17:30:58Z

I think the AppVeyor failure here is a network timeout (probably unrelated to this change).

Other than that, I think this is good to go. Official fully-working Python 3.5 support!

embray · 2015-09-15T18:35:01Z

fingers crossed Once this passes I'll try to get v1.0.5 out.

mdboom · 2015-09-16T15:11:16Z

This seems to be good to go.

embray · 2015-09-16T17:12:50Z

👍

embray · 2015-09-16T17:13:39Z

This seems to have crept in from #4147 somehow.

embray · 2015-09-16T17:16:50Z

Thanks in particular for updating all the argument parsing stuff--that looks like it was a pain.

WIP: Python 3.5 support

astrofrog · 2015-09-16T20:18:27Z

Thanks @mdboom! \o/

WIP: Python 3.5 support Conflicts: .travis.yml astropy/cosmology/core.py astropy/modeling/core.py astropy/modeling/utils.py astropy/stats/bayesian_blocks.py astropy/time/formats.py astropy/utils/tests/test_decorators.py astropy/visualization/hist.py

mdboom added this to the Future milestone Jul 31, 2015

mdboom added the build label Jul 31, 2015

mdboom force-pushed the python-3.5 branch from e0ff386 to 4ff0b95 Compare August 6, 2015 13:32

mdboom force-pushed the python-3.5 branch from f2a2d92 to d5b1f43 Compare August 24, 2015 15:34

embray mentioned this pull request Sep 14, 2015

Add Python 3.5 to Travis #4155

Closed

mdboom force-pushed the python-3.5 branch 2 times, most recently from 5933f17 to 9049a1f Compare September 14, 2015 18:49

embray added the Affects-release label Sep 14, 2015

embray modified the milestones: v1.0.5, Future Sep 14, 2015

mdboom added 5 commits September 14, 2015 16:55

Update for Python 3.5

b388332

Fix signature on Python 3.x

a970132

Use final version of 3.5

2738e58

And CHANGES entry

30e63bb

Cleanup

20dc895

mdboom force-pushed the python-3.5 branch from 43fe464 to 20dc895 Compare September 14, 2015 20:55

astrofrog reviewed Sep 14, 2015
View reviewed changes

Make Python 3.5 an allowed failure

6de5eeb

mdboom added 6 commits September 15, 2015 11:58

Update py.test

5c6b4c2

Rename classes look like test suites but aren't

7f117e0

py.test 2.7.3 now warns about these things

Register the remote_data marker

749e6a7

This is now required in py.test 2.7.3

Ignore DeprecationWarning in py.test

a4021b1

Disable a logger test on Python 3.5

21e4856

Re-enable Travis test on Python 3.5

e6b066c

mdboom added 2 commits September 15, 2015 13:31

Mention Python 3.5 support in the docs

63ee01a

Fix broken link to pytest.raises

f423c8d

embray reviewed Sep 16, 2015
View reviewed changes

Remove extraneous CHANGE entry

96e0f0a

embray added a commit that referenced this pull request Sep 16, 2015

Merge pull request #4027 from mdboom/python-3.5

c9eb861

WIP: Python 3.5 support

embray merged commit c9eb861 into astropy:master Sep 16, 2015

embray mentioned this pull request Sep 17, 2015

Overly verbose test result output #4164

Closed

astrofrog mentioned this pull request Sep 29, 2015

Support Python 3.5 #4025

Closed

Conversation

mdboom commented Jul 31, 2015

Uh oh!

mdboom commented Jul 31, 2015

Uh oh!

astrofrog commented Aug 1, 2015

Uh oh!

mdboom commented Aug 3, 2015

Uh oh!

embray commented Aug 3, 2015

Uh oh!

mdboom commented Aug 3, 2015

Uh oh!

embray commented Aug 3, 2015

Uh oh!

mdboom commented Aug 6, 2015

Uh oh!

embray commented Aug 6, 2015

Uh oh!

mdboom commented Aug 6, 2015

Uh oh!

mdboom commented Sep 14, 2015

Uh oh!

astrofrog commented Sep 14, 2015

Uh oh!

mdboom commented Sep 14, 2015

Uh oh!

embray commented Sep 14, 2015

Uh oh!

embray commented Sep 14, 2015

Uh oh!

embray commented Sep 14, 2015

Uh oh!

astrofrog Sep 14, 2015

Choose a reason for hiding this comment

Uh oh!

mdboom Sep 14, 2015

Choose a reason for hiding this comment

Uh oh!

mdboom commented Sep 14, 2015

Uh oh!

mdboom commented Sep 15, 2015

Uh oh!

mdboom commented Sep 15, 2015

Uh oh!

mdboom commented Sep 15, 2015

Uh oh!

embray commented Sep 15, 2015

Uh oh!

mdboom commented Sep 16, 2015

Uh oh!

embray commented Sep 16, 2015

Uh oh!

embray Sep 16, 2015

Choose a reason for hiding this comment

Uh oh!

mdboom Sep 16, 2015

Choose a reason for hiding this comment

Uh oh!

embray commented Sep 16, 2015

Uh oh!

astrofrog commented Sep 16, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants