Repository navigation
Match __repr__ to attribute - #4147
Conversation
In constant.py, rename units -> unit and error -> uncertainty to match __repr__ to attributes.
|
Note: Old PR was #4146. 👍 It seems uncontraversial. I would lean towards a change log, because why not? |
|
I think indeed it is best to err in the direction of too much information: @dienz-bonn: could you add an entry to the file In the commit message for that change, you can add "[skip ci]", so that travis does not run again, and then this can be merged. Thanks! |
|
Sorry for the misspelled id, @dlenz-bonn |
Document renaming of units and error in __repr__ in the changes.
|
Thanks for the help, I added the changes to the change log. Note that I changed my username as well, but the commits should appear with the old id. |
|
Great, thanks! Merging... |
|
Why should this be limited to v1.1.0? This change can be backported to the v1.0.x branch. |
There was a problem hiding this comment.
This should have been "uncertainty" in lowercase.
|
I'm putting this in 1.0.5. |
4 participants
Rename Error -> Uncertainty and Units -> Unit in
__repr__to match the attributes.Requested in #4145
Had to re-do the pull request because I messed up the branches.