Skip to content

Minor changes to Sgr coordinate frame example - #5637

Merged
eteq merged 1 commit into
astropy:masterfrom
adrn:docs/sgr-example-units
Dec 22, 2016
Merged

eteq merged 1 commit into
astropy:masterfrom
adrn:docs/sgr-example-units

Conversation

@adrn

@adrn adrn commented Dec 22, 2016

Copy link
Copy Markdown
Member

This fixes #5555

@mhvk what did you mean about using units for the plot axes?

@eteq

eteq commented Dec 22, 2016

Copy link
Copy Markdown
Member

This is definitely an improvement and pretty trivial, so I'm going to merge it now so that it can be in the 1.3 docs.

I think what @mhvk meant is something like the plotting quantities example, right? I think in this case that's not really useful because angular plots already have the "degree" symbol there - and for matplotlib angular projections it's important that it be provided as radians anyway, otherwise the projection stuff goes super wonky.

So I'll merge this, but keep #5555 open on the theory that @mhvk should have the final say there on whether or not this satisfies that issue.

@eteq eteq added this to the v1.3.0 milestone Dec 22, 2016
@eteq
eteq merged commit a91c57a into astropy:master Dec 22, 2016
eteq added a commit that referenced this pull request Dec 22, 2016
Minor changes to Sgr coordinate frame example
@mhvk

mhvk commented Dec 22, 2016

Copy link
Copy Markdown
Contributor

I did indeed mean also using the matplotlib units methods, but that was less important than what was done here: have obvious unit conversions without using quantity. So, fine to just leave it at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sgr coordinates example use units throughout

3 participants