Skip to content

Limit pytest to <3.2 for circleci tests - #6420

Merged
bsipocz merged 1 commit into
astropy:masterfrom
larrybradley:circleci-pytest
Aug 2, 2017
Merged

bsipocz merged 1 commit into
astropy:masterfrom
larrybradley:circleci-pytest

Conversation

@larrybradley

Copy link
Copy Markdown
Member

This is a temporary fix for #6418 related to astropy/ci-helpers#222, which does this for AppVeyor and travis. CircleCI is not included in astropy-ci as it is used only by the core package and a few affiliated packages (e.g. photutils and regions).

@astropy-bot

astropy-bot Bot commented Aug 2, 2017 •

Copy link
Copy Markdown

Hi there @larrybradley 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

@bsipocz

bsipocz commented Aug 2, 2017

Copy link
Copy Markdown
Member

photutils seems to be OK for pytest 3.2, at least local tests and my latest PR both passed.

@larrybradley

Copy link
Copy Markdown
Member Author

@bsipocz Yes, we don't have any marked parameter xfails in photutils.

@larrybradley larrybradley added this to the v2.0.2 milestone Aug 2, 2017
@bsipocz

bsipocz commented Aug 2, 2017

Copy link
Copy Markdown
Member

@larrybradley - There was one: astropy/photutils#578, but the other doctest related issue somehow doesn't come up there.

@bsipocz
bsipocz merged commit 58a5a38 into astropy:master Aug 2, 2017
@bsipocz bsipocz mentioned this pull request Aug 2, 2017
@larrybradley
larrybradley deleted the circleci-pytest branch August 2, 2017 22:29
bsipocz added a commit that referenced this pull request Aug 8, 2017
Limit pytest to <3.2 for circleci tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants