Skip to content

What's new sections for v4.0 - #9581

Merged
bsipocz merged 28 commits into
astropy:masterfrom
astrofrog:whatsnew-4.0
Dec 3, 2019
Merged

bsipocz merged 28 commits into
astropy:masterfrom
astrofrog:whatsnew-4.0

Conversation

@astrofrog

@astrofrog astrofrog commented Nov 11, 2019 •

Copy link
Copy Markdown
Member

The goal of this PR is to add entries to the 'What's new in v4.0?'. I've added section headings for things I think are worth highlighting, but of course we could add/remove if needed. I suggest that we try and write all of these as part of a single PR as it will make it easier to go over after and make sure everything is consistent etc.

So if you would like to write one or more of these sections (or another section that is missing) please either just push a commit directly to my whatsnew-4.0 branch or open a PR to my branch if you prefer or don't have the adequate permissions to push to my branch. If you aren't sure how to do either of these, feel free to ping me on slack.

I'm going to tag and assign people who've been involved in developing the functionality/changes in this page or oversaw the relevant PRs:

If you don't have time to work on this over the next few days, please put a message and I'll find someone else who can write it or I can write it myself.

Tips:

Once most of the sections are here I'll go over and try and make sure everything is consistent.

@adrn

adrn commented Nov 11, 2019

Copy link
Copy Markdown
Member

Putting @lglattly on notice: We will want you to copy edit this PR once it is text-complete!

@pllim pllim added this to the v4.0 milestone Nov 11, 2019
@adrn

adrn commented Nov 12, 2019

Copy link
Copy Markdown
Member

You should be able to rebase now that #9582 is merged, but I'm slightly disturbed that nothing is failing because of my addition to the whats new!

@astrofrog

Copy link
Copy Markdown
Member Author

@adrn - I had added IGNORE_OUTPUT to some of the lines in your examples so I could test mine and forgot to then remove those flags. If I remove them then I get failures in this PR with the dict of references, and after rebasing those failures go away.

@aarchiba

Copy link
Copy Markdown
Contributor

I've made a PR with some description, but I wasn't sure of the format or how best to arrange for it to be included here.

@astrofrog astrofrog changed the title WIP: What's new sections for v4.0 What's new sections for v4.0 Nov 25, 2019
@astrofrog

astrofrog commented Nov 25, 2019 •

Copy link
Copy Markdown
Member Author

@aarchiba - thanks! Your changes are now included here :)

@lglattly - this is now ready for copy editing, thanks!

Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
@lglattly

Copy link
Copy Markdown
Contributor

I made some copy editing suggestions that you can take or leave as you see fit!

@bsipocz

bsipocz commented Nov 27, 2019

Copy link
Copy Markdown
Member

Hmm, it's quite annoying, I was clicking through all the copy edit comments, but at the end couldn't commit them due to permission error. Anyway, once they are in, this should be good to go.

Comment thread docs/whatsnew/4.0.rst Outdated
Comment thread docs/whatsnew/4.0.rst Outdated
@pllim

pllim commented Dec 2, 2019

Copy link
Copy Markdown
Member

A glance through the rendered doc didn't raise any red flags, except for the potential typo in above comment. Once that is resolved, this can be merged.

Co-Authored-By: P. L. Lim <[email protected]>
@pllim pllim added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Dec 2, 2019
@bsipocz
bsipocz merged commit cddb5b8 into astropy:master Dec 3, 2019
@bsipocz

bsipocz commented Dec 3, 2019

Copy link
Copy Markdown
Member

Thanks @astrofrog and everyone else involved!

bsipocz added a commit that referenced this pull request Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.