Skip to content

test: preserve zoom precondition in grouping e2e - #538

Closed
richardfogaca wants to merge 1 commit into
compozy:mainfrom
richardfogaca:test/zoom-grouping-contract
Closed

test: preserve zoom precondition in grouping e2e#538
richardfogaca wants to merge 1 commit into
compozy:mainfrom
richardfogaca:test/zoom-grouping-contract

Conversation

@richardfogaca

@richardfogaca richardfogaca commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What & why

E2E-137 opened a visible peer after zooming the Tasks window. The current shell contract intentionally exits zoom when that peer is revealed, so the test cleared its own precondition before asking the grouping reducer to cross desktops. Open and identify the peer first, then arrange and zoom Tasks before the explicit grouping action.

This preserves every zoom, grouping, and unzoom assertion while aligning setup with the shell behavior introduced by #525.

An AI coding agent co-wrote this change. I independently verified the result.

How you verified it

  • E2E-137: 3 consecutive runs passed.
  • make gate with Node 22: 722 web test files and 6,423 tests passed.
  • make web-build: passed.
  • Independent exact-delta review: no findings.

Impact

Test-only change. No CLI command, HTTP/UDS route, configuration key, web product surface, or documentation behavior changes. The Compozy Impact Audit found no native tool, extension, hook, workspace-isolation, or official-skill impact.

  • make gate passes locally; this PR is delivered only after its required CI checks are green
  • New or changed behavior is covered by tests, or I explained above why not
  • If an agent wrote or co-wrote this, I named it above and verified the result myself

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
compozy-site Skipped Skipped Sep 2, 2026 4:54am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • web/e2e/__tests__/os-shell.spec.ts is excluded by !web/e2e/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 45eec85b-c486-4df4-af92-bfed24576d57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@richardfogaca richardfogaca mentioned this pull request Sep 2, 2026
Merged
3 tasks done
@richardfogaca

richardfogaca commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

The exact zoom-precondition E2E fix from this draft is now included in consolidated draft #536 at head 90503026. Recommendation: review #536 as the single base-CI stabilization path; keep this PR open until a maintainer confirms closure after that path is accepted.

@richardfogaca

richardfogaca commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Supersession receipt: #536 head 9b3bed95 is code-CI green and contains this draft's exact patch (acdc6f91 ≡ 011805cd, stable patch-id 044026af). Vercel authorization is the only external red status. Leaving this draft open for maintainer closure.

@pedronauck
pedronauck marked this pull request as ready for review September 2, 2026 19:03
@pedronauck
pedronauck self-requested a review as a code owner September 2, 2026 19:03
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

This test-only change opens and identifies the Agents window before arranging and zooming Tasks, preserving the cross-desktop grouping precondition.

  • Moves Agents setup ahead of the Tasks/Settings arrangement and zoom action.
  • Retains the existing grouping, zoom, and unzoom assertions.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The reordered setup preserves Agents as a floating window on the default desktop while Tasks is lifted by zoom, so the test continues to exercise cross-desktop grouping without clearing its zoom precondition.

Important Files Changed
Filename Overview
web/e2e/tests/os-shell.spec.ts Reorders E2E-137 setup so opening Agents cannot clear Tasks' zoom state; reducer semantics preserve Agents on the default desktop until grouping.

Reviews (1): Last reviewed commit: "test: preserve zoom precondition in grou..." | Re-trigger Greptile

This branch was previously deployed

1 inactive deployment
Preview — acdc6f91 Deployed Sep 2, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@richardfogaca