Repository navigation
testing: the two remaining pre-Chainsaw e2e-apps suites are executed by nothing #3638
Description
Summary
hack/e2e-apps/monitoring-oidc-system.bats and hack/e2e-apps/monitoring-oidc-customconfig.bats are run by nothing. BATS_UNIT_FILES is built from a non-recursive $(wildcard hack/*.bats), so the unit lane never sees the subdirectory; packages/core/testing/Makefile does not reference them; no workflow calls them. Their headers say "What is exercised here on a live cluster", both are executable, and both were edited as recently as a month ago (3776c44), so they read as live coverage while being dead weight.
Three independent looks converged on this within one day: a review of the TIA fail-safe change identified them as the last two unported files from the pre-Chainsaw suite whose only surviving references are "Chainsaw port of ..." comments; the per-file EXIT-trap ratchet work found the unit lane structurally cannot run them; and the capture-gating work found that a filename-prefix rule derived from the top-level convention would have mis-classified them, precisely because nothing enforces any convention inside the subdirectory.
Selection is also blind to them today
full_suite_pattern in hack/select-e2e.sh matches hack/[^/]+\.bats$ only, so an edit inside hack/e2e-apps/ does not even escalate to the full e2e suite: the files neither run nor cause anything else to run. (The TIA fail-safe change under review closes the escalation half by sending unclassified paths to the full suite; it does not make the files themselves run.)
Decision needed
Either finish the Chainsaw port that the in-tree comments already promise and delete the pair, or delete them now and keep the port as an ordinary feature request. Keeping executable "live cluster" suites that nothing executes is the worst of the options: they rot invisibly and mislead anyone auditing coverage.
Activity
lexfrei commentedon Aug 8, 2026
Cost update that sharpens the decision: with the fail-safe selection change in flight, edits under
hack/e2e-apps/escalate to the full e2e suite via the unclassified-path fall-through (measured on a half-year replay: 119 such commits would now buy a full run). So the orphaned pair stops being free dead weight: every touch of these files costs a complete suite run while the files themselves still execute nowhere. That tilts the trade further toward deciding soon, either finishing the port or deleting them.lexfrei commentedon Aug 8, 2026
One more reference site for whoever resolves this:
hack/cozytest.shjustifies its directory-based capture-arming branch with "hack/e2e-apps/ holds live-cluster suites" (line 123 at the current main). The branch itself is a defensible forward-guard and is pinned by a test, but its justification cites coverage that does not exist. Whichever way this issue resolves, port or delete, that sentence needs the matching edit, or it becomes the next inherited-false-comment for the directory.chore(tests): remove the two dead monitoring OIDC bats suites
lexfrei commentedon Sep 30, 2026
Both suites were deleted in #4019, so there is nothing left to run or wire up. Porting the monitoring OIDC coverage to Chainsaw is tracked in #4051 and #3785.