[monitoring-agents] Set minReplicas to 1 for VPA for VMAgent by sircthulhu · Pull Request #1894 · cozystack/cozystack

Kirill Ilin (sircthulhu) · 2026-01-20T13:03:06Z

What this PR does

Set minReplicas for VPA for VMAgent to work correctly in the default case when replicas = 1
Fixes #1893

Release note

[monitoring-agents] set minReplicas=1 in VPA for cluster-wide VMAgent to allow recrating single replica

Summary by CodeRabbit

Changes

Chores
- Updated system monitoring autoscaler configuration to enforce minimum replica constraints, enhancing service resilience and availability during scaling operations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Signed-off-by: Kirill Ilin <[email protected]>

gemini-code-assist · 2026-01-20T13:03:20Z

Summary of Changes

Hello Kirill Ilin (@sircthulhu), I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial configuration change to the Vertical Pod Autoscaler (VPA) for the VMAgent component. By setting minReplicas to 1, the VPA is now properly configured to handle scenarios where the VMAgent operates with a single replica, resolving an issue that could prevent correct recreation or scaling behavior. This change enhances the robustness and reliability of the monitoring agents within the system.

Highlights

VPA Configuration Update: The Vertical Pod Autoscaler (VPA) configuration for the VMAgent has been updated to explicitly set minReplicas to 1. This ensures that the VPA correctly manages the VMAgent, especially when it is running as a single replica.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	Gemini (@gemini-code-assist)	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2026-01-20T13:03:38Z

📝 Walkthrough

Walkthrough

A single configuration constraint was added to the VerticalPodAutoscaler template for monitoring-agents. The minReplicas: 1 field was inserted into the spec.updatePolicy section to ensure the VMAgent maintains at least one replica during autoscaling updates, preventing VPA from scaling below the single-replica operational requirement.

Changes

Cohort / File(s)	Summary
VerticalPodAutoscaler Configuration `packages/system/monitoring-agents/templates/vpa.yaml`	Added `minReplicas: 1` constraint to `spec.updatePolicy` to enforce minimum replica count during autoscaling

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny tweak, but oh so grand,

One replica now takes its stand,

VPA knows: don't scale below,

VMAgent shall steadily flow! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately summarizes the main change: setting minReplicas to 1 in the VPA configuration for VMAgent monitoring.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#1893` by adding minReplicas: 1 to the VPA updatePolicy, enabling VPA to update single-replica VMAgent deployments.
Out of Scope Changes check	✅ Passed	All changes are scoped to the VPA configuration for VMAgent; only minReplicas field was added with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request correctly configures the Vertical Pod Autoscaler (VPA) for VMAgent by setting minReplicas: 1. This change is necessary to allow the VPA's updater to function correctly when VMAgent is deployed with a single replica, ensuring that resource recommendations can be applied by recreating the pod. The change is well-targeted and effectively resolves the issue of VPA not working for single-replica VMAgent deployments.

Andrei Kvapil (kvaps) · 2026-01-22T16:57:18Z

/retest

github-actions · 2026-01-22T22:17:27Z

Successfully created backport PR for release-0.41:

[Backport release-0.41] [monitoring-agents] Set minReplicas to 1 for VPA for VMAgent #1905

…VPA for VMAgent (#1905) # Description Backport of #1894 to `release-0.41`.

[monitoring-agents] Set minReplicas to 1 for VPA for VMAgent

207a517

Signed-off-by: Kirill Ilin <[email protected]>

Kirill Ilin (sircthulhu) requested review from Andrei Kvapil (kvaps), Timofei Larkin (lllamnyp) and Nikita (nbykov0) as code owners January 20, 2026 13:03

dosubot Bot added size/XS This PR changes 0-9 lines, ignoring generated files kind/bug Categorizes issue or PR as related to a bug labels Jan 20, 2026

gemini-code-assist Bot reviewed Jan 20, 2026

View reviewed changes

Timofei Larkin (lllamnyp) approved these changes Jan 20, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Jan 20, 2026

Andrei Kvapil (kvaps) added the kind/backport Categorizes issue or PR as requiring a backport to the current release line label Jan 22, 2026

Andrei Kvapil (kvaps) merged commit a805aef into main Jan 22, 2026
37 of 39 checks passed

Andrei Kvapil (kvaps) deleted the fix-vpa-for-vmagent branch January 22, 2026 22:17

github-actions Bot mentioned this pull request Jan 22, 2026

[Backport release-0.41] [monitoring-agents] Set minReplicas to 1 for VPA for VMAgent #1905

Merged

Andrei Kvapil (kvaps) added a commit that referenced this pull request Jan 22, 2026

[Backport release-0.41] [monitoring-agents] Set minReplicas to 1 for …

a24174a

…VPA for VMAgent (#1905) # Description Backport of #1894 to `release-0.41`.

Navigation Menu

Repository navigation

[monitoring-agents] Set minReplicas to 1 for VPA for VMAgent - #1894

[monitoring-agents] Set minReplicas to 1 for VPA for VMAgent#1894
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-vpa-for-vmagent

Kirill Ilin (sircthulhu) commented Jan 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

gemini-code-assist Bot commented Jan 20, 2026

Uh oh!

coderabbitai Bot commented Jan 20, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Andrei Kvapil (kvaps) commented Jan 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Kirill Ilin (sircthulhu) commented Jan 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Release note

Summary by CodeRabbit

Changes

Uh oh!

gemini-code-assist Bot commented Jan 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Andrei Kvapil (kvaps) commented Jan 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kirill Ilin (sircthulhu) commented Jan 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 20, 2026 •

edited

Loading