Repository navigation
Make no particle chain in a part that holds no name word (#636) - #639
Merged
Merged
Conversation
A part past the second comma, and the part after a suffix comma, read wholly as suffixes with their title words as titles (C2), but group still ran the particle chain over them, building a name unit no reading uses: `John Smith, Jr., van der Berg Prof.` read suffix 'Jr., van der Berg Prof.' where `John Smith, Jr., Prof.` reads title 'Prof.'. Group now makes no chain there and asks no bound for one, so C2 reads every title word in the part, bare or mid-part. Narrower and cheaper than the #623 bound the issue proposed, which reads trailing titles only. Measured against 3b2b6f0: 18,318 of #624's comma-tail grid parses move, 15,330 a title word into the title field and 2,988 a particle back out of a title the chain had joined; no corpus name, case text or other grid moves. Five gates exit 0. Tail parts cost fewer frames. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 46 46
Lines 4511 4512 +1
=======================================
+ Hits 4467 4468 +1
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A chain kept in a part past the second comma after a FAMILY comma alone passed every test, though it reverts readings; rows for `Smith, John, van der Berg Prof.` and the empty head `,, van der Berg Prof.` hold it. The part after a suffix comma has reached no chain since #613, decide binding it and emptying its segment before any join, so #636 changes only parts past the second comma: the entry, the code comment and a case note said otherwise and are corrected. The tail half of group's report handoff is dead with no chain there and is removed (nothing moves). C2's Accepted paragraph is narrowed to its report half, and the entry names its population against 3b2b6f0 and records the review's measurements and two gaps already on master. Co-Authored-By: Claude Opus 5.5 <[email protected]>
With the report handoff's tail half gone, the full-revival negative control fails 9 tests, the existing report row among them, not 4. The suffix-comma grid and the handoff's measurement now give their recipes, the review's unrecorded sweep quotes no count, #544's entry marks its mechanism superseded, and the entry opens #640 and #641. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A part past the second comma, after either comma, is read entirely as suffixes, with its title words read as titles (C2, #603). Group still ran the particle chain over it, which builds a name unit no reading uses. A particle past the part's first word took the words behind it, including any title word among them.
The part after a suffix comma, which C2 also covers, has reached no chain since #613:
_comma.decidebinds it and empties its segment before any join. A suffix-comma grid of 606,216 parses moves nothing here (recipe in the decisions entry).John Smith, Jr., van der Berg Prof.John Smith, Jr., van der Prof. BergJohn Smith, Jr., van Berg Prof.vanchains nothing, P4)John Smith, Jr., Prof.Group now makes no chain in such a part and asks for no chain bound there. C2 then reads every title word in the part, whether bare (
Prof) or mid-part.Decided (Derek): this approach, rather than the issue's proposal of #623's
trailing_run_startbound at this site. That bound reads trailing titles only (H5), which is narrower than C2's rule, and it adds a call where removing the chain takes one away. The chain's two report emitters were already handed no report list in these parts, for the same reason. With no chain there, there is nothing to suppress.Measured (against 3b2b6f0, py3.11, import asserted on each side; grid recipe in decisions.md#P2's 2026-10-10 #624 entry)
Freiherr St John Smith MAstart: should a title that is also a particle open the name? #624's comma-tail grid (97,650 texts, three orders) plus every corpus name and case text: 18,318 parses on 6,106 texts move a role. All of them are in the grid; none of master's corpus names or case texts move, and no parse moves only a report.,, 'Bob' van der Attorneybecomes title 'Attorney', suffix 'van der'.,, 'Bob' van der Mr. and Mrs.as title 'der Mr. and Mrs.'.Freiherr St John Smith MAstart: should a title that is also a particle open the name? #624's title-particle grid, ShouldSmith, John van der Berg Prof.read title 'Prof.' asJohn van der Berg Prof.does? #623's given-part grid or Merge the trailing run's particle runs in group, so S2's read needs no BOUND stop or report gathering #625's particle grid.fix(#636)rule.fix(comma-family) lone post-comma piece routes to suffix/titlerule already explains the new example, and its claim is re-recorded with a dated note.John Smith, Jr., Freiherr von Richthofen440 → 428).Tests
New row
a_title_behind_a_particle_run_past_the_second_comma, labelledfix(#636). 1.4.0 and 2.3.0 read suffix 'Jr., van der Berg Prof.'.Two new rules.md#C2 examples.
New rows from the review:
Smith, John, van der Berg Prof.and,, van der Berg Prof.(bothfix(#636)). A chain kept after a family comma alone had passed every other test while reverting these readings.Negative control: with the chain run in these parts again, 9 tests fail.
fix(#636)rows, on both surfaces.a_part_past_the_second_reports_no_particle_fork: the handoff no longer suppresses its chain report, so that row now guards the change too.With the chain run only after a family comma, the two review rows fail on both surfaces.
Review
Fix commit:
The grid sweep ran under 13 configurations, comparing fields, reports,
initials(),capitalized()and the facade's views, and found no reading made worse.Two gaps were already on master and are recorded in the entry:
John Smith, Jr., abdul Dr. Smith): ShouldJohn Smith, Jr., abdul Dr. Smithread title 'Dr.' asJohn Smith, Jr., Berg Dr. Smithdoes? #640.John Smith, PhD van der Bergreport its words as possible name words, when C2 says a wholly-suffix part raises no such report? #641.Second fix commit:
John Smith, PhD MEngreads firstPhD, lastJohn Smith#544's mechanism superseded;John Smith, Jr., abdul Dr. Smithread title 'Dr.' asJohn Smith, Jr., Berg Dr. Smithdoes? #640 and ShouldJohn Smith, PhD van der Bergreport its words as possible name words, when C2 says a wholly-suffix part raises no such report? #641 in the entry.Docs
John Smith, Jr., van der Berg Prof.read title 'Prof.' asJohn Smith, Jr., Prof.does? #636 entry.John Smith, PhD Jonesreads familyJohn Smith#603 C2 bullet is extended and now closes ShouldJohn Smith, Jr., van der Berg Prof.read title 'Prof.' asJohn Smith, Jr., Prof.does? #636.Closes #636
🤖 Generated with Claude Code