Repository navigation
Decline a title word a trailing rule reads, in the bound join (#637, #640) - #643
Merged
Merged
Conversation
…640) P5's bound given-name join took the word after `abdul` even where a trailing rule would read it as a title, so the joined piece was no title word: `Berg, abdul Prof.` read given 'abdul Prof.' where `Berg, John Prof.` reads title 'Prof.' (#637), and `John Smith, Jr., abdul Dr. Smith` read suffix 'Jr., abdul Dr. Smith' (#640). The join now declines such a word: after a family comma one H5's trailing run takes from the given part, and in a part past the second comma any title word, which C2 reads. A title word standing in the name still joins (`abdul Sir Smith Berg`), as P5 states. Decided (Derek): this narrower clause over declining every title word, which split real joins. Measured against 4455962: 1,044 of 15,552 bound-given grid parses move, each a title word into the title field; 280 of #623's given-part grid, the same class; among corpus names and case texts only the row that pinned the gap. Five gates exit 0. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #643 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 46 46
Lines 4512 4513 +1
=======================================
+ Hits 4468 4469 +1
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The decline after a family comma asks H5's run as the comma-less name reads it, and the given part's walk reads some words behind a title otherwise (a numeral VI to X, V before a third part, a title-particle P6 attaches): there the join is declined and no title is read. Garbage shapes, recorded rather than narrowed as #623's disagreement was, and stated in an Accepted clause of rules.md#P5; the entry no longer says every move gains a title, and its #623-grid count names the 20 that do not. Rows pin the bare-title half past the second comma and the whole trailing run after a family comma, which no test held. Corrected: option (a)'s count (3,000 joins split, not 1,944), the negative controls (11 and 5), a row note's history (#603), a ledger note naming the wrong rule, the entry's place in the P5 section, notes on the #623 and #614 entries, P5/C2 interacts, two release sentences. The site is asked before the title test, so a comma-less bound name pays no frame for it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
rules.md#H5's Accepted paragraph said the title is read after a family comma, which P5's new Accepted clause now excepts; the frames sentence gains the family-comma bound name with no title behind it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P5's bound given-name join takes the word after
abdul. It already declined a maiden marker and a suffix piece, but it took a title word even where a trailing rule would have read that word as a title. The joined piece was then no title word to read:Berg, abdul Prof.(#637)John Smith, Jr., abdul Dr. Smith(#640)Berg, abdul Prof. Aliabdul Sir Smith BergThe join now declines a title word that a trailing rule reads as a title:
tail_readingis asked here, and only when a title word follows the bound word.Decided (Derek): this narrower clause (a′), not declining every title word (a). P5 states that a title word standing in the name is a name word and joins like one (H3), and (a) undid that:
(Bob), Abu Bishop→ given 'Abu', middle 'Bishop').Measured (against 4455962, py3.11, import asserted on each side; recipes in decisions.md#P5)
John Smith, Jr., Abu Bishop Ali Smith→ title 'Bishop', as C2 already readsJohn Smith, Jr., Bishop.Smith, John van der Berg Prof.read title 'Prof.' asJohn van der Berg Prof.does? #623's given-part grid: 280 moves. 260 are the same class. The other 20 split the join with no title read (Smith, abdul Prof. V, Jr.), the limit recorded below.Berg, abdul Prof., the row that had pinned the gap.Freiherr St John Smith MAstart: should a title that is also a particle open the name? #624's title-particle grid or Merge the trailing run's particle runs in group, so S2's read needs no BOUND stop or report gathering #625's particle grid.fix(#637)andfix(#640)rules. ShouldSmith, abdul Dr.read title 'Dr.' asSmith, abdul Ali Dr.andabdul Smith Dr.do? #637's fields differ by baseline: 2.0.0 and 2.1.0 read middle 'Prof.', while 2.2.0 and 2.3.0 read given 'abdul Prof.'.Berg, abdul salam208 → 209).Berg, abdul Bishop208 → 218).Tests
title_word_trailing_behind_a_bound_pair_after_a_comma(Berg, abdul Prof.) used to pin the gap as a non-normative row. It now pins the title, asfix(#637).a_bound_join_declines_a_title_past_the_second_comma,fix(#640).Berg, abdul Prof. Aliboundary. rules.md#H5's gap paragraph becomes an example.John Smith, Jr., abdul Sir Smith(fix(#640)): the bare-title half.Berg, abdul Prof. Dr.(fix(#637)): the whole trailing run rather than the last word.Review
Recorded, not narrowed. After a family comma, the decline asks how the comma-less name would read H5's run, and the given part's own reading differs on some shapes. There the join is declined and no title is read:
Smith, abdul Prof. VI→ middle 'Prof. VI')Smith, abdul St.→ family 'St. Smith')A bound word that is also a particle, before a dotted title-particle, goes the other way: the title is read where an ordinary given word doesn't read it (
Smith, Abu St.→ title 'St.';Smith, Zed St.→ family 'St. Smith').All of these are garbage input, recorded the same way as #623's disagreement, and rules.md#P5 states them in an Accepted clause. The sweep found nothing reading worse than master on a real name, and no comma-less name moved.
Fix commit:
Smith, John van der Berg Prof.read title 'Prof.' asJohn van der Berg Prof.does? #623 entry and toabdul Smith Jr Maloses the family name — P5's reserve does not mirror S2's bare-acronym fork #425's paragraph on the post-comma path (which renders under Rethink the credential-run rule (S2): read a name's trailing run once, over name units, and bind it before any join #614's bullet);interacts;Second fix commit: H5's Accepted paragraph now excepts the shapes P5 records, and the frames sentence gains the family-comma case.
Docs
Closes #637
Closes #640
🤖 Generated with Claude Code