Repository navigation
Record the lessons of #623 through #641 in AGENTS.md - #645
Merged
Merged
Conversation
Five, each named for the PR and the input that showed it: re-take a recorded negative control after the last commit that adds tests (three went stale in a row); a mutation that moves nothing shows code unexercised, not dead (#638); a claim that a change restores the released reading is measured over the moved population, and a population size is re-counted, never copied (#625); a group-side predictor of the family comma's given part via `tail_reading` disagrees with the walk on three shapes, an accepted gap (#623, #637); and the title-particles go in every head list in both spellings (#637). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 46 46
Lines 4513 4513
=======================================
Hits 4469 4469
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This records five lessons from #623 through #641 in AGENTS.md. Each one is a defect that a check written down earlier would have caught. Following AGENTS.md's own rule, each names the PR and the input that showed it, and goes where the next person will meet it. Four amend existing paragraphs; one is a new Gotchas entry.
John Smith, Jr., van der Berg Prof.read title 'Prof.' asJohn Smith, Jr., Prof.does? #636 (4 → 9) and ShouldSmith, abdul Dr.read title 'Dr.' asSmith, abdul Ali Dr.andabdul Smith Dr.do? #637 (5 → 7 → 11).Smith, Freiherr van Berg X.Y.Z.), and the issue closed the same day.Freiherr St John Smith MAstart: should a title that is also a particle open the name? #624's grid size (137,810) for a grid of 395,148.tail_readingdisagrees with the given part's own walk on three shapes: a shape-only numeral VI to X, V before a third comma part, and a title-particle that P6 attaches. This hit ShouldSmith, John van der Berg Prof.read title 'Prof.' asJohn van der Berg Prof.does? #623's chain bound and ShouldSmith, abdul Dr.read title 'Dr.' asSmith, abdul Ali Dr.andabdul Smith Dr.do? #637's join decline. Both were recorded rather than narrowed.freiherr,st) go in every head list in both bare and period-marked spellings. ShouldSmith, abdul Dr.read title 'Dr.' asSmith, abdul Ali Dr.andabdul Smith Dr.do? #637's grid had only the bare forms, and missedSt.andFreiherr..Docs only; the doc tests pass.
🤖 Generated with Claude Code