Skip to content

Record the lessons of #623 through #641 in AGENTS.md - #645

Merged
derek73 merged 1 commit into
masterfrom
docs/agents-lessons-623-641
Oct 11, 2026
Merged

derek73 merged 1 commit into
masterfrom
docs/agents-lessons-623-641

Conversation

@derek73

@derek73 derek73 commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Summary

This records five lessons from #623 through #641 in AGENTS.md. Each one is a defect that a check written down earlier would have caught. Following AGENTS.md's own rule, each names the PR and the input that showed it, and goes where the next person will meet it. Four amend existing paragraphs; one is a new Gotchas entry.

  1. Workflow, guard tests. Re-take a recorded negative control after the last commit that adds tests, before merge. Three in a row went stale when a review round added rows: Merge the trailing run's particle runs in group, so S2's read needs no BOUND stop or report gathering #625 (27 → 30), Should John Smith, Jr., van der Berg Prof. read title 'Prof.' as John Smith, Jr., Prof. does? #636 (4 → 9) and Should Smith, abdul Dr. read title 'Dr.' as Smith, abdul Ali Dr. and abdul Smith Dr. do? #637 (5 → 7 → 11).
  2. Gotchas, null results. A mutation that moves nothing shows code unexercised by your grids, not dead code. Remove group's chain re-ask after its own merges, which no longer changes a reading #638 was filed calling group's chain re-ask dead. The next review found 400 moves (Smith, Freiherr van Berg X.Y.Z.), and the issue closed the same day.
  3. Release-log claims. A claim that a change restores the released reading has to be measured over the whole moved population. A population size is re-counted from its recipe, never copied from another entry. Merge the trailing run's particle runs in group, so S2's read needs no BOUND stop or report gathering #625 claimed its moves landed on the 1.4.0 and 2.3.0 readings from three names; measured, 0 of 258 did. The same entry copied Where does Freiherr St John Smith MA start: should a title that is also a particle open the name? #624's grid size (137,810) for a grid of 395,148.
  4. Gotchas, new entry. A group-side predictor of a family comma's given part that asks tail_reading disagrees with the given part's own walk on three shapes: a shape-only numeral VI to X, V before a third comma part, and a title-particle that P6 attaches. This hit Should Smith, John van der Berg Prof. read title 'Prof.' as John van der Berg Prof. does? #623's chain bound and Should Smith, abdul Dr. read title 'Dr.' as Smith, abdul Ali Dr. and abdul Smith Dr. do? #637's join decline. Both were recorded rather than narrowed.
  5. Sweep paragraph. The title-particles (freiherr, st) go in every head list in both bare and period-marked spellings. Should Smith, abdul Dr. read title 'Dr.' as Smith, abdul Ali Dr. and abdul Smith Dr. do? #637's grid had only the bare forms, and missed St. and Freiherr..

Docs only; the doc tests pass.

🤖 Generated with Claude Code

Five, each named for the PR and the input that showed it: re-take a
recorded negative control after the last commit that adds tests (three
went stale in a row); a mutation that moves nothing shows code
unexercised, not dead (#638); a claim that a change restores the
released reading is measured over the moved population, and a
population size is re-counted, never copied (#625); a group-side
predictor of the family comma's given part via `tail_reading`
disagrees with the walk on three shapes, an accepted gap (#623, #637);
and the title-particles go in every head list in both spellings (#637).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@derek73 derek73 added the docs Documentation fixes and updates label Oct 11, 2026
@derek73 derek73 self-assigned this Oct 11, 2026
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (b15393d) to head (40b50e5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          46       46           
  Lines        4513     4513           
=======================================
  Hits         4469     4469           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit 6dae824 into master Oct 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation fixes and updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant