Repository navigation
ref-utils: Improve error message intelligibility - #6753
genodeftest wants to merge 1 commit into
Conversation
Solves a problem where flatpak would print a non-helpful error message if the disallowed character is a space.
|
Example problem: I ran |
| else | ||
| flatpak_fail_error (error, FLATPAK_ERROR_INVALID_NAME, | ||
| _("Name can't contain %c"), *s); | ||
| _("Name can't contain »%c«"), *s); |
There was a problem hiding this comment.
Isn't that usually just normal quotes: "Name can't contain \"%c\""?
Also the commit message should have a prefix and be a bit more specific: ref-utils: Improve error message in flatpak_is_valid_name
|
@genodeftest ping |
|
There is a more general issue here, which is that if we log I'm trying to fix this more generally, resolving the technical debt from #6768. |
I have a branch for this, but I'm unable to push to Github right now - I'll try again later and see whether their servers have sorted themselves out. |
While I'm changing the translatable string anyway, this also incorporates a suggestion from flatpak#6753 to quote the invalid character, so that output is clearer in the case where the invalid character is whitespace. Thanks: Christian Stadelmann Signed-off-by: Simon McVittie <[email protected]>
|
Closing in favor of #6795. Thanks @genodeftest. |
While I'm changing the translatable string anyway, this also incorporates a suggestion from flatpak#6753 to quote the invalid character, so that output is clearer in the case where the invalid character is whitespace. Thanks: Christian Stadelmann Signed-off-by: Simon McVittie <[email protected]>
While I'm changing the translatable string anyway, this also incorporates a suggestion from flatpak#6753 to quote the invalid character, so that output is clearer in the case where the invalid character is whitespace. Thanks: Christian Stadelmann Signed-off-by: Simon McVittie <[email protected]>
|
Thanks for taking care and providing a better fix! I'm sorry I didn't respond earlier, I was on the roads and didn't find time to do this properly. |
While I'm changing the translatable string anyway, this also incorporates a suggestion from #6753 to quote the invalid character, so that output is clearer in the case where the invalid character is whitespace. Thanks: Christian Stadelmann Signed-off-by: Simon McVittie <[email protected]> Cherry-picked-from: 5f3f7a8
3 participants
Solves a problem where flatpak would print a non-helpful error message if the disallowed character is a space or other whitespace character.