Mac native_platform_view_ui_tests_ios has been failing consistently #106745

Activity

1. keyonghan

   added

   platform-iosiOS applications specificallyiOS applications specifically

   on Jun 28, 2022
2. hellohuanlin

   self-assigned this

   on Jul 6, 2022
3. jmagman commented on Jul 7, 2022

   

   jmagman

   on Jul 7, 2022

   Member

   More actions

   This is failing because the test needs Xcode to be installed, but it's not set up as a dependency. See conversation at #105050 (comment).
4. zanderso commented on Jul 28, 2022

   

   zanderso

   on Jul 28, 2022

   Member

   More actions

   Clicked on this today out curiosity. It is failing with "Task failed: DeviceException: No connected physical iOS devices found." What is the next AI for this test?
5. hellohuanlin commented on Jul 28, 2022

   

   hellohuanlin

   on Jul 28, 2022

   Contributor

   More actions

   @zanderso working on it (with help from @keyonghan)
6. jmagman commented on Jul 29, 2022

   

   jmagman

   on Jul 29, 2022

   Member

   More actions

   The issue is that this was set up as a hostonly devicelab test since it's running on a simulator and not a physical device. However the devicelab test harness requires a tethered device, or the device discovery will fail the test if there isn't a tethered device, or the right kind of tethered device.

   #108585 was a hacky attempt to set the android_sdk as a dependency in case the tethered device was an Android device, since it just doesn't matter as long as it's running on a Mac. However, that didn't work:

   Task result:
   {
     "success": false,
     "reason": "Task failed: DeviceException: No Android devices detected"
   }
   

   One of the below should happen for this test:

   1. Be changed to run on a physical device
   2. Be moved out of devicelab to flutter_drone since it doesn't need a tethered device, either to a tools integration test per [flutter_tools] Migrate hostonly_devicelab tests to flutter_tools #65790 or instead to a shard? Or somewhere else?
7. jmagman commented on Jul 29, 2022

   

   jmagman

   on Jul 29, 2022

   Last edited by jmagman

   Member

   More actions

   The issue is that this was set up as a hostonly devicelab test since it's running on a simulator and not a physical device.

   Well this was totally untrue, I misremembered what this test is doing. It is trying to run on a physical device, and it's failing because it's set up to check for a tethered Android device.
   

   flutter/dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart

   Line 36 in b00bfef

   final Device device = await devices.workingDevice;

   So ignore everything from the last comment. 🙂

   The .ci.yaml entry should become something like

     - name: Mac_ios native_platform_view_ui_tests_ios
       bringup: true
       recipe: devicelab/devicelab_drone
       timeout: 60
       properties:
         tags: >
           ["devicelab", "ios", "mac"]
         task_name: native_platform_view_ui_tests_ios
   

   Then the top of the test needs

   deviceOperatingSystem = DeviceOperatingSystem.ios;

   👍React with 👍1Reacted by hellohuanlin
8. hellohuanlin commented on Aug 2, 2022

   

   hellohuanlin

   on Aug 2, 2022

   Contributor

   More actions

   This is fixed. Looks like dashboard still shows flaky, but when i go into the log it shows not flaky.
9. hellohuanlin

   closed this as completedon Aug 2, 2022
10. github-actions commented on Aug 16, 2022

    

    github-actionsbot

    on Aug 16, 2022

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
11. github-actions

    locked as resolved and limited conversation to collaborators on Aug 16, 2022