Skip to content

ScrollbarPainter clean up #107181

Closed
#107179
Closed
ScrollbarPainter clean up#107181
#107179
Assignees
Piinks
Labels
P1High-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight

Description

@Piinks
Piinks
opened on Jul 6, 2022

The scrollbar painter has a bit of code rot.

While working on #13253, I found it hard to follow the painter logic and found several little bugs. This really needs a clean up to make it easier to work with. Some of the bugs I found have to do with padding and margins, these should likely be wrapped in consistent getters to use across the all of the painter methods.

Found bugs:

Fix is in #107179

Activity

  1. Piinks
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    frameworkflutter/packages/flutter repository. See also f: labels.
    f: scrollingViewports, list views, slivers, etc.
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Jul 6, 2022
  2. Piinks
    self-assigned this
    on Jul 6, 2022
  3. Piinks
    added
    waiting for PR to land (fixed)A fix is in flight
    on Jul 6, 2022
  4. goderbauer
    added
    P1High-priority issues at the top of the work list
    on Jul 6, 2022
  5. auto-submit
    closed this as completedin #107179on Aug 3, 2022

  6. github-actions commented on Aug 18, 2022

    @github-actions
    github-actionsbot
    on Aug 18, 2022

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions