framework canvaskit cache is not being cleared with engine rolls #123737

Activity

1. kevmoo

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   platform-webWeb applications specificallyWeb applications specifically

   P1

   on Mar 30, 2023
2. kevmoo

   assigned

   eyebrowsoffire

   on Mar 30, 2023
3. auto-submit

   closed this as completedin #123739on Mar 30, 2023
4. kevmoo commented on Mar 31, 2023

   

   kevmoo

   on Mar 31, 2023

   ContributorAuthor

   More actions

   @eyebrowsoffire – reports that this is NOT fixed - #123794 (comment)
5. eyebrowsoffire

   reopened this on Apr 1, 2023
6. eyebrowsoffire commented on Apr 1, 2023

   

   eyebrowsoffire

   on Apr 1, 2023

   Contributor

   More actions

   Re-opening due to further issues here. #123915 should fix it though.
7. auto-submit

   closed this as completedin #123915on Apr 4, 2023
8. darshankawar commented on Apr 6, 2023

   

   darshankawar

   on Apr 6, 2023

   Member

   More actions

   Hello @kevmoo and @eyebrowsoffire

   I tried running a sample app on web flutter run -d chrome using latest master and main channels but still seeing below error:

   Launching lib/main.dart on Chrome in debug mode...
   Waiting for connection from debug service on Chrome...             20.0s
   This app is linked to the debug service: ws://127.0.0.1:49414/M2WfAhbvFAY=/ws
   Debug service listening on ws://127.0.0.1:49414/M2WfAhbvFAY=/ws
   
   🔥  To hot restart changes while running, press "r" or "R".
   For a more detailed help message, press "h". To quit, press "q".
   
   A Dart VM Service on Chrome is available at: http://127.0.0.1:49414/M2WfAhbvFAY=
   Rejecting promise with error: Expected a value of type 'FontCollectionNamespace', but got one of type 'Null'
   _js_helper.TypeErrorImpl.new
   
   
   

   master version: Channel master, 3.9.0-22.0.pre.56, on macOS 12.2.1 21D62

   main version: Channel main, 3.9.0-22.0.pre.56, on macOS 12.2.1 21D62

   👍React with 👍1Reacted by Francesco Iapicca
9. eyebrowsoffire

   reopened this on Apr 6, 2023
10. eyebrowsoffire commented on Apr 6, 2023

    

    eyebrowsoffire

    on Apr 6, 2023

    Contributor

    More actions

    @darshankawar I haven't been able to reproduce this on my end. Does this still reproduce after you clear the browser cache?
11. darshankawar commented on Apr 10, 2023

    

    darshankawar

    on Apr 10, 2023

    Member

    More actions

    @eyebrowsoffire
    No. After following #123794 (comment), I didn't get the said error, although earlier I thought that it was more of a workaround until this original issue gets fixed, so thought to report it here for your reference.
12. mit-mit commented on Apr 10, 2023

    

    mit-mit

    on Apr 10, 2023

    Member

    More actions

    It looks like #123784 was closed as a dupe of the present issue, but I just hit it again in dart-lang/sdk#51998

    I think we have to fix this for 3.10!

    👍React with 👍1Reacted by Kevin Moore
13. eyebrowsoffire commented on Apr 12, 2023

    

    eyebrowsoffire

    on Apr 12, 2023

    Contributor

    More actions

    After some digging, I was able to get my setup into a state that reproduced this problem, and I have put out a fix: #124641
14. eyebrowsoffire commented on Apr 12, 2023

    

    eyebrowsoffire

    on Apr 12, 2023

    Contributor

    More actions

    To give a more clear characterization of this bug:

    Users who had the flutter repo checked out between #121902 and #123915 and used a web-based flutter tool command (such as flutter run -d chrome or flutter build web) will have stale canvaskit versions in their cache in an old location. Those artifacts confuse the web runner, and cause it to serve these stale versions of canvaskit. This, in turn, causes the user's application to crash when they run flutter run -d chrome with newer versions of the framework.

    From what I can tell, none of the existing tags (3.6, 3.7, 3.8, 3.9 or 3.10) fall within the range between those two PRs, and do not load any of these stale artifacts in the cache. #124641 fixes the issue for anyone in that state. Otherwise, the workaround is to manually delete the bin/cache/canvaskit folder.
15. mit-mit commented on Apr 12, 2023

    

    mit-mit

    on Apr 12, 2023

    Member

    More actions

    OK, the fairly short window to trigger the issue lowers the priority a bit, and its nice that there is a workaround. BUT when it fails, it fails in a way that is very hard to understand (I got JS interop issues), so I still think we should pick the fix if we think it's relatively low risk of causing regressions.

    👍React with 👍3Reacted by Kevin Moore, Jackson Gardner and Francesco Iapicca
16. auto-submit

    closed this as completedin #124641on Apr 12, 2023
17. darshankawar

    added

    r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

    on Apr 13, 2023
18. github-actions commented on Apr 27, 2023

    

    github-actionsbot

    on Apr 27, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
19. github-actions

    locked as resolved and limited conversation to collaborators on Apr 27, 2023
20. flutter-triage-bot

    added

    P0Critical issues such as a build break or regressionCritical issues such as a build break or regression

    and removed

    P1

    on Jun 28, 2023