Skip to content

SearchBar open search view on tap when enabled option in the SearchBar is set to false #150331

Closed
#153256
Closed
SearchBar open search view on tap when enabled option in the SearchBar is set to false#150331
#153256
Labels
P2Important issues not at the top of the work listfound in release: 3.22Found to occur in 3.22found in release: 3.23Found to occur in 3.23frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onp: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Description

@silentlie
silentlie
opened on Jun 17, 2024

Steps to reproduce

  1. Create a simple SearchAnchor and return SearchBar in the builder.
  2. Set the enabled option in the SearchBar to false.
  3. Run and click on SearchBar.

Expected results

Expect to be ignored on tap call
1

Actual results

Open search view instead
1

Code sample

Code sample 
        SearchAnchor(
          builder: (BuildContext context, SearchController controller) {
            return const SearchBar(
              enabled: false,
            );
          },
          suggestionsBuilder:
              (BuildContext context, SearchController controller) {
            return [];
          },
        ),

Screenshots or Video

Screenshots / Video demonstration

1

Logs

Logs 




Flutter Doctor output


Doctor output

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4529], locale en-AU)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.9.6)
[√] Android Studio (version 2023.2)
[√] VS Code, 64-bit edition (version 1.90.0)
[√] Connected device (3 available)
[√] Network resources

• No issues found!


Activity
  1. darshankawar
    added 
    in triagePresently being triaged by the triage team
     on Jun 17, 2024
  2. darshankawar commented on Jun 17, 2024 
    @darshankawar
    darshankawar
    on Jun 17, 2024
    Member
    Thanks for the report. I was able to replicate the reported behavior on latest versions in all platforms. With enabled: false, the textfield is still enabled and accepts input. The property was added as part of #137388
    

    
 stable, master flutter doctor -v 

    [!] Flutter (Channel stable, 3.22.2, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.22.2 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (33 hours ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.23.0-13.0.pre.242, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.23.0-13.0.pre.242 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5187cab7bd (2 days ago), 2024-06-14 23:35:34 -0400
    • Engine revision 9779c273aa
    • Dart version 3.5.0 (build 3.5.0-266.0.dev)
    • DevTools version 2.36.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.
      
[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.




    

    

    /cc @Macacoazul01
  3. darshankawar
    added 
    frameworkflutter/packages/flutter repository. See also f: labels.
     
    p: material_uimaterial_ui package in flutter/packages
     
    has reproducible stepsThe issue has been confirmed reproducible and is ready to work on
     
    team-designOwned by Design Languages team
     
    found in release: 3.22Found to occur in 3.22
     
    found in release: 3.23Found to occur in 3.23
     and removed 
    in triagePresently being triaged by the triage team
     on Jun 17, 2024
  4. Piinks
    added 
    triaged-designTriaged by Design Languages team
     
    P2Important issues not at the top of the work list
     on Jun 20, 2024
  5. Macacoazul01 commented on Jun 27, 2024 
    @Macacoazul01
    Macacoazul01
    on Jun 27, 2024
    Contributor
    @darshankawar im finishing an update for my app these days so my free time is really short right now. Gonna try a fix for this right after the update lands.
  6. Macacoazul01 commented on Aug 3, 2024 
    @Macacoazul01
    Macacoazul01
    on Aug 3, 2024
    Contributor
    @silentlie with the SearchBar only is everything ok?
  7. silentlie commented on Aug 4, 2024 
    @silentlie
    silentlie
    on Aug 4, 2024
    Author
    

    @silentlie with the SearchBar only, is everything ok?
    

    

    It's fined for now. I'd hide the search bar if I don't want it to be enabled. But it'd be better for it to be disabled for aesthetics
  8. Macacoazul01 commented on Aug 12, 2024 
    @Macacoazul01
    Macacoazul01
    on Aug 12, 2024
    Contributor
    @darshankawar, @silentlie this PR should fix the problem.
  9. Macacoazul01 commented on Aug 14, 2024 
    @Macacoazul01
    Macacoazul01
    on Aug 14, 2024
    Contributor
    @darshankawar who is responsible for the review of this one?
    
The tests went ok!
  10. darshankawar commented on Aug 14, 2024 
    @darshankawar
    darshankawar
    on Aug 14, 2024
    Member
    @Macacoazul01 You may request review as suggested and also add @Piinks
    
Screenshot 2024-08-14 at 10 31 52 AM
  11. auto-submit
    closed this as completedin #153256on Sep 4, 2024
  12. auto-submit
    closed this as completedin ce15e3bon Sep 4, 2024
  13. fluttermirroringbot
    added a commit that references this issue on Sep 4, 2024
    added enabled to search anchor (#153256)
    ce15e3b
  14. darshankawar
    added 
    r: fixedIssue is closed as already fixed in a newer version
     on Sep 5, 2024
  15. github-actions commented on Sep 19, 2024 
    @github-actions
    github-actionsbot
    on Sep 19, 2024 – with GitHub Actions
    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
  16. github-actions
    locked as resolved and limited conversation to collaborators on Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Metadata
Assignees
No one assigned
    Labels
    P2Important issues not at the top of the work listfound in release: 3.22Found to occur in 3.22found in release: 3.23Found to occur in 3.23frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onp: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team
    Type
    No type
    Projects
    No projects
      Milestone
      No milestone
      Relationships
      None yet
      Development
      No branches or pull requests
      Issue actions