Expose 'enable' property to allow the user to disable the SearchBar by Macacoazul01 · Pull Request #137388 · flutter/flutter

Macacoazul01 · 2023-10-27T02:11:57Z

This exposes the enabled property of the TextField widget to the Searchbar widget.

Related Issues

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

Still missing tests

flutter-dashboard · 2023-10-27T02:11:59Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

QuncCccccc

Thanks a lot for the contribution!

The SearchBar also has a InkWell to show different effects when hover, focused, pressed etc. So if we only disable the text field, we still can see the effects in these states as if the search bar is still enabled. This behavior might look a little strange.

To show a disabled effect for InkWell, we might also need to handle MaterialStates when the search bar is disabled:)

Macacoazul01 · 2023-11-02T00:51:55Z

saw this behavior when testing the PR and it was strange. Thanks for pointing where i should look for

flutter-dashboard · 2023-11-22T00:52:16Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Macacoazul01 · 2023-11-25T11:44:47Z

@QuncCccccc Ready for the review.

QuncCccccc

Thanks for the fix! As the issue #136943 mentioned, search bar should be greyed out so users can notice it is disabled. We currently don't have a disabled spec from Material Design but usually we use opacity 0.38 to "disable" widgets(such as a disabled Card). So we can use Opacity and do:

return Opacity(
  opacity: widget.enabled? 1 : 0.38,
  child: ConstrainedBox(...)
)

Does this make sense?

Macacoazul01 · 2023-12-12T18:47:24Z

Ok. I can add this.
When are you able to review again?

Macacoazul01 · 2023-12-12T18:48:39Z

Everything except this disabled color is ok?

QuncCccccc · 2023-12-12T21:12:53Z

Everything except this disabled color is ok?

Yep! Overall this looks good to me:) We can also check the opacity in the unit test. As for the disabled opacity number 0.38, could you also put this as a constant at the top of the file search_anchor.dart. That's where we put all these numbers:)

Macacoazul01 · 2023-12-14T01:02:23Z

@QuncCccccc added the opacity and the test. Can you review, please?

justinmc

LGTM with nits. Thanks for the PR!

justinmc · 2024-01-08T17:22:31Z

-                      textInputAction: widget.textInputAction,
-                      keyboardType: widget.keyboardType,
+      child: Opacity(
+        opacity: widget.enabled ? 1 : _kDisableSearchBarOpacity,


Super nit: 1.0 instead of 1.

QuncCccccc · 2024-01-10T22:32:39Z

@Macacoazul01 Could you rebase master to trigger the tests again? I don't think the test failures are related to your change.

Macacoazul01 · 2024-01-11T13:53:08Z

Finaly

…rchBar (flutter/flutter#137388)

flutter/flutter@9f2e681...7dc856a 2024-01-12 [email protected] Revert "Reverts "Run iOS staging tests with Xcode 15.2"" (flutter/flutter#141420) 2024-01-12 [email protected] Roll Packages from 0744fe6 to d74d687 (5 revisions) (flutter/flutter#141449) 2024-01-12 [email protected] Fix `FlexibleSpaceBar` centered title position and title color (flutter/flutter#140883) 2024-01-12 [email protected] Do not reset framework checkout before running customer tests (flutter/flutter#141013) 2024-01-12 [email protected] Increase delay for checking integration_ui_keyboard_resize test success (flutter/flutter#141301) 2024-01-12 [email protected] Add osx_sdk context for mac builds. (flutter/flutter#141422) 2024-01-12 [email protected] Roll Flutter Engine from ecdaed76f284 to 44a0a6ee4d39 (18 revisions) (flutter/flutter#141432) 2024-01-12 [email protected] Add support for Gradle Kotlin DSL (flutter/flutter#140744) 2024-01-12 [email protected] Fix typo (flutter/flutter#141426) 2024-01-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run iOS staging tests with Xcode 15.2" (flutter/flutter#141412) 2024-01-11 [email protected] Run iOS staging tests with Xcode 15.2 (flutter/flutter#141392) 2024-01-11 [email protected] Fix `ListWheelScrollView` in an `AnimatedContainer` with zero height throw an error (flutter/flutter#141372) 2024-01-11 [email protected] make asset_test.dart tests not dependent on context (flutter/flutter#141331) 2024-01-11 [email protected] Expose 'enable' property to allow the user to disable the SearchBar (flutter/flutter#137388) 2024-01-11 [email protected] Add impeller key to skia gold client, Turn on a framework test shard that will run unit tests with --enable-impeller (flutter/flutter#141341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Macacoazul01 · 2024-03-30T15:31:03Z

@HansMuller will this land on the next stable?

HansMuller · 2024-04-01T16:51:04Z

Yes, it should be part of the next stable release.

Added the same parameter from #137388 to the `SearchAnchor` This PR will fix: #150331

flutter/flutter@9f2e681...7dc856a 2024-01-12 [email protected] Revert "Reverts "Run iOS staging tests with Xcode 15.2"" (flutter/flutter#141420) 2024-01-12 [email protected] Roll Packages from 0744fe6 to d74d687 (5 revisions) (flutter/flutter#141449) 2024-01-12 [email protected] Fix `FlexibleSpaceBar` centered title position and title color (flutter/flutter#140883) 2024-01-12 [email protected] Do not reset framework checkout before running customer tests (flutter/flutter#141013) 2024-01-12 [email protected] Increase delay for checking integration_ui_keyboard_resize test success (flutter/flutter#141301) 2024-01-12 [email protected] Add osx_sdk context for mac builds. (flutter/flutter#141422) 2024-01-12 [email protected] Roll Flutter Engine from ecdaed76f284 to 44a0a6ee4d39 (18 revisions) (flutter/flutter#141432) 2024-01-12 [email protected] Add support for Gradle Kotlin DSL (flutter/flutter#140744) 2024-01-12 [email protected] Fix typo (flutter/flutter#141426) 2024-01-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run iOS staging tests with Xcode 15.2" (flutter/flutter#141412) 2024-01-11 [email protected] Run iOS staging tests with Xcode 15.2 (flutter/flutter#141392) 2024-01-11 [email protected] Fix `ListWheelScrollView` in an `AnimatedContainer` with zero height throw an error (flutter/flutter#141372) 2024-01-11 [email protected] make asset_test.dart tests not dependent on context (flutter/flutter#141331) 2024-01-11 [email protected] Expose 'enable' property to allow the user to disable the SearchBar (flutter/flutter#137388) 2024-01-11 [email protected] Add impeller key to skia gold client, Turn on a framework test shard that will run unit tests with --enable-impeller (flutter/flutter#141341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@9f2e681...7dc856a 2024-01-12 [email protected] Revert "Reverts "Run iOS staging tests with Xcode 15.2"" (flutter/flutter#141420) 2024-01-12 [email protected] Roll Packages from b67b257 to a49ee07 (5 revisions) (flutter/flutter#141449) 2024-01-12 [email protected] Fix `FlexibleSpaceBar` centered title position and title color (flutter/flutter#140883) 2024-01-12 [email protected] Do not reset framework checkout before running customer tests (flutter/flutter#141013) 2024-01-12 [email protected] Increase delay for checking integration_ui_keyboard_resize test success (flutter/flutter#141301) 2024-01-12 [email protected] Add osx_sdk context for mac builds. (flutter/flutter#141422) 2024-01-12 [email protected] Roll Flutter Engine from ecdaed76f284 to 44a0a6ee4d39 (18 revisions) (flutter/flutter#141432) 2024-01-12 [email protected] Add support for Gradle Kotlin DSL (flutter/flutter#140744) 2024-01-12 [email protected] Fix typo (flutter/flutter#141426) 2024-01-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run iOS staging tests with Xcode 15.2" (flutter/flutter#141412) 2024-01-11 [email protected] Run iOS staging tests with Xcode 15.2 (flutter/flutter#141392) 2024-01-11 [email protected] Fix `ListWheelScrollView` in an `AnimatedContainer` with zero height throw an error (flutter/flutter#141372) 2024-01-11 [email protected] make asset_test.dart tests not dependent on context (flutter/flutter#141331) 2024-01-11 [email protected] Expose 'enable' property to allow the user to disable the SearchBar (flutter/flutter#137388) 2024-01-11 [email protected] Add impeller key to skia gold client, Turn on a framework test shard that will run unit tests with --enable-impeller (flutter/flutter#141341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

added enabled property

f12b1b4

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Oct 27, 2023

Macacoazul01 added 4 commits October 27, 2023 19:02

Merge branch 'flutter:master' into search-anchor

b8cb792

Update search_test.dart

b6118b9

add missing part

7c2e1d7

Update search_anchor.dart

bcbd633

HansMuller requested a review from QuncCccccc November 1, 2023 18:25

Merge branch 'master' into search-anchor

25691f7

QuncCccccc reviewed Nov 2, 2023

View reviewed changes

Macacoazul01 and others added 4 commits November 24, 2023 21:10

Merge branch 'master' into search-anchor

60ff32b

ignore textfield when disabled

c2932e7

fix search_anchor.dart

f3bcd2f

Update search_anchor.dart

1bb7a72

Macacoazul01 requested a review from QuncCccccc November 27, 2023 11:47

Merge branch 'master' into search-anchor

1331c48

QuncCccccc reviewed Dec 12, 2023

View reviewed changes

Macacoazul01 and others added 2 commits December 12, 2023 20:21

Merge branch 'flutter:master' into search-anchor

595b423

search bar opacity and test

47b3d2a

Macacoazul01 requested a review from QuncCccccc December 14, 2023 01:02

Macacoazul01 added 2 commits December 15, 2023 20:47

Merge branch 'master' into search-anchor

72b8e1c

Merge branch 'master' into search-anchor

31b870e

Macacoazul01 and others added 2 commits January 5, 2024 19:30

Merge branch 'master' into search-anchor

5711bbd

fix import

1cdebcd

justinmc approved these changes Jan 8, 2024

View reviewed changes

remove extra line

12f2b80

Merge branch 'master' into search-anchor

670eab3

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 11, 2024

auto-submit Bot merged commit e281c39 into flutter:master Jan 11, 2024

engine-flutter-autoroll mentioned this pull request Jan 12, 2024

Roll Flutter from 9f2e681e7be6 to e20d34c38a9b (13 revisions) flutter/packages#5878

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2024

e281c39 Expose 'enable' property to allow the user to disable the Sea…

c2f02ac

…rchBar (flutter/flutter#137388)

engine-flutter-autoroll mentioned this pull request Jan 12, 2024

Roll Flutter from 9f2e681e7be6 to 52d2c1210994 (14 revisions) flutter/packages#5880

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2024

e281c39 Expose 'enable' property to allow the user to disable the Sea…

e58ddf5

…rchBar (flutter/flutter#137388)

engine-flutter-autoroll mentioned this pull request Jan 12, 2024

Roll Flutter from 9f2e681e7be6 to 7dc856ab8423 (15 revisions) flutter/packages#5882

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 12, 2024

e281c39 Expose 'enable' property to allow the user to disable the Sea…

e46064f

…rchBar (flutter/flutter#137388)

Macacoazul01 deleted the search-anchor branch January 18, 2024 00:38

Macacoazul01 restored the search-anchor branch January 18, 2024 00:38

Macacoazul01 deleted the search-anchor branch January 18, 2024 00:38

HansMuller mentioned this pull request Jan 19, 2024

Flutter Framework Team: Notable Commits #121415

Closed

HansMuller mentioned this pull request Feb 1, 2024

Disable option for SearchBar #136943

Closed

2 tasks done

darshankawar mentioned this pull request Jun 17, 2024

SearchBar open search view on tap when enabled option in the SearchBar is set to false #150331

Closed

Macacoazul01 mentioned this pull request Aug 12, 2024

added enabled to search anchor #153256

Merged

9 tasks done

auto-submit Bot pushed a commit that referenced this pull request Sep 4, 2024

added enabled to search anchor (#153256)

ce15e3b

Added the same parameter from #137388 to the `SearchAnchor` This PR will fix: #150331

Conversation

Macacoazul01 commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Oct 27, 2023

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Macacoazul01 commented Nov 2, 2023

Uh oh!

flutter-dashboard Bot commented Nov 22, 2023

Uh oh!

Macacoazul01 commented Nov 25, 2023

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Macacoazul01 commented Dec 12, 2023

Uh oh!

Macacoazul01 commented Dec 12, 2023

Uh oh!

QuncCccccc commented Dec 12, 2023

Uh oh!

Macacoazul01 commented Dec 14, 2023

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Jan 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QuncCccccc commented Jan 10, 2024

Uh oh!

Macacoazul01 commented Jan 11, 2024

Uh oh!

Macacoazul01 commented Mar 30, 2024

Uh oh!

HansMuller commented Apr 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Macacoazul01 commented Oct 27, 2023 •

edited

Loading