Repository navigation
added enabled to search anchor - #153256
Merged
Merged
Conversation
github-actions
Bot
added
framework
QuncCccccc
approved these changes
Aug 21, 2024
QuncCccccc
left a comment
QuncCccccc
left a comment
Contributor
There was a problem hiding this comment.
LGTM:) Thanks for the contribution!
Renzo-Olivares
approved these changes
Aug 21, 2024
justinmc
reviewed
Aug 21, 2024
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
Maybe it's kind of not ideal that you'll have to pass enabled: false to both SearchBar and SearchAnchor, but I guess that's the best we can do with that builder approach. So I think this approach looks good, just some small code and docs comments. Thanks for the PR!
Co-authored-by: Qun Cheng <[email protected]>
Co-authored-by: Qun Cheng <[email protected]>
change docs
justinmc
reviewed
Aug 29, 2024
justinmc
reviewed
Aug 29, 2024
Contributor
Author
|
@justinmc the only viable option that i found was with
When When |
justinmc
approved these changes
Sep 3, 2024
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Take a look at getOpacity though, I think it can be private.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the same parameter from #137388 to the
SearchAnchorThis PR will fix: #150331
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.