Repository navigation
Heroes don't handle inherited properties #213
Description
Activity
- added this to the milestone
on Nov 9, 2015 Changing the milestone, since this blocks #4436 .
This is not going to happen any time soon, if ever.
We are going to close this for now because it's not obvious what a solution should in fact be. We will revisit this when we have more concrete needs, e.g. from a customer.
If you want this please don't hesitate to open a new bug.
- added a commit that references this issue
on Mar 21, 2019 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Sep 4, 2021
Tuesday Oct 20, 2015 at 17:59 GMT
Originally opened as https://github.com/flutter/engine/issues/1698
When we do a hero transition, we need to interpolate any inherited properties that the heroes use from the source to the target. For example, font sizes need to grow when animating from somewhere where the default text style is body1 to somewhere where the default text style is display2. Colours need to crossfade when transitioning from somewhere with primaryColor purple to primaryColor green. Etc.