Skip to content

Heroes don't handle inherited properties #213

Closed
Closed
Heroes don't handle inherited properties#213
Labels
customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Description

@FlutterIssues
FlutterIssues
opened on Nov 9, 2015

Issue by Hixie
Tuesday Oct 20, 2015 at 17:59 GMT
Originally opened as https://github.com/flutter/engine/issues/1698

When we do a hero transition, we need to interpolate any inherited properties that the heroes use from the source to the target. For example, font sizes need to grow when animating from somewhere where the default text style is body1 to somewhere where the default text style is display2. Colours need to crossfade when transitioning from somewhere with primaryColor purple to primaryColor green. Etc.

Activity

  1. FlutterIssues
    added this to the milestone on Nov 9, 2015
  2. FlutterIssues
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Nov 9, 2015
  3. Hixie
    added
    p: material_uimaterial_ui package in flutter/packages
    ⚠ bug
    on Nov 20, 2015
  4. mpcomplete
    modified the milestones: Gallery App, on Jul 19, 2016

  5. mpcomplete commented on Jul 19, 2016

    @mpcomplete
    mpcomplete
    on Jul 19, 2016
    Contributor

    Changing the milestone, since this blocks #4436 .

  6. sethladd
    added
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on Jul 22, 2016
  7. Hixie
    modified the milestones: Gallery App, on Sep 16, 2016
  8. Hixie
    removed
    old: bug (tell Hixie today if you don't want this label deleted)
    on Jan 12, 2017

  9. Hixie commented on Mar 1, 2017

    @Hixie
    Hixie
    on Mar 1, 2017
    Contributor

    This is not going to happen any time soon, if ever.

  10. Hixie
    modified the milestones: , 2: Make Early Adopters happy on Mar 1, 2017

  11. Hixie commented on Jun 6, 2017

    @Hixie
    Hixie
    on Jun 6, 2017
    Contributor

    We are going to close this for now because it's not obvious what a solution should in fact be. We will revisit this when we have more concrete needs, e.g. from a customer.

    If you want this please don't hesitate to open a new bug.

  12. Hixie
    closed this as completedon Jun 6, 2017
  13. Letty-Liang
    added a commit that references this issue on Mar 21, 2019

    Fix a g++ package name on Ubuntu Xenial (flutter#213)

    1931770

  14. github-actions commented on Sep 4, 2021

    @github-actions
    github-actionsbot
    on Sep 4, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. github-actions
    locked as resolved and limited conversation to collaborators on Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions