You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FR: BottomNavigationBar fixed with no titles #22882
It's definitely encouraged to have the Material library be a superset of features in the guidelines! But we should not add this particular feature as we believe it creates a worse a11y experience.
This request is not outside the mainstream for app design and I believe it is quite reasonable even though it is omitted from Material spec. I would argue that the shifting icons are less accessible because they break procedural knowledge when they move position and they require localization.
Best thing you can do is write to [email protected] and state your case. CC me: [email protected]. If you sway them then we’d def intend to have this feature.
If they don’t, then @jonahwilliams will need his a11y concerns allayed.
I don't think I should be the arbiter of whether or not this meets the guidelines for a11y. We can provide caveats and documentation but ultimately we're not the arbiters of how users develop apps. I also don't want to create a situation where we have a lot of customizations supported in the framework which have to be documented with "Don't use this if ...".
Some potential action items:
Can we abstract the concept of the bottom nav into widgets?
Though detangling the material specific properties might be difficult. Then we could have a more generic view which just took a Widget for the tabs.
Can a bottom nav bar without titles (material or not) be accessible via other properties or sufficient labels?
Allowing people to still give the buttons a title and if that can be read through other means (such as speech) that might work? I'm not too familiar with a11y and will look into it more.
The Specification shows examples of buttons that show and reveal their text, but they do not shift side to side. This is the major issue that I am trying to resolve (along with gaining height on the screen).
The shifting side to side animation on Flutters BNB is distracting, not specified by MD, and confusing for users. (And by users, I mean me. It's not like I've tested it or anything!)
Reacted by Will Larche, Hyo and Yurii Cherniavskyi
Ah! Well that’s different. The fastest way for that to be solved is for you to put in a PR. Otherwise this will be triaged and prioritized for a later date.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
hyochan commentedon Oct 11, 2018
@lukepighetti Got
PRfor you.jonahwilliams commentedon Oct 11, 2018
I don't believe material bottom navigation bars are spec'd for not having a title, nor would those meet a11y requirements without them. cc @willlarche
Not that there couldn't be a bottom navigation without titles, but I don't think it belongs in the material library if it's not part of the spec.
lukepighetti commentedon Oct 11, 2018
How do we do a PR on the spec? 😇
willlarche commentedon Oct 11, 2018
It's definitely encouraged to have the Material library be a superset of features in the guidelines! But we should not add this particular feature as we believe it creates a worse a11y experience.
lukepighetti commentedon Oct 12, 2018
This request is not outside the mainstream for app design and I believe it is quite reasonable even though it is omitted from Material spec. I would argue that the shifting icons are less accessible because they break procedural knowledge when they move position and they require localization.
willlarche commentedon Oct 12, 2018
Best thing you can do is write to [email protected] and state your case. CC me: [email protected]. If you sway them then we’d def intend to have this feature.
If they don’t, then @jonahwilliams will need his a11y concerns allayed.
jonahwilliams commentedon Oct 12, 2018
I don't think I should be the arbiter of whether or not this meets the guidelines for a11y. We can provide caveats and documentation but ultimately we're not the arbiters of how users develop apps. I also don't want to create a situation where we have a lot of customizations supported in the framework which have to be documented with
"Don't use this if ...".Some potential action items:
widgets?Though detangling the material specific properties might be difficult. Then we could have a more generic view which just took a Widget for the tabs.
lukepighetti commentedon Oct 12, 2018
I was imagining a scenario where this collapsed the padding under the icon.
Or maybe
Allowing people to still give the buttons a title and if that can be read through other means (such as speech) that might work? I'm not too familiar with a11y and will look into it more.
lukepighetti commentedon Oct 12, 2018
Actually, looking over the spec I think Flutter's BottomNavigationBar gratuitously moves outside the Material Design specification.
https://material.io/design/components/bottom-navigation.html#specs
The Specification shows examples of buttons that show and reveal their text, but they do not shift side to side. This is the major issue that I am trying to resolve (along with gaining height on the screen).
The shifting side to side animation on Flutters BNB is distracting, not specified by MD, and confusing for users. (And by users, I mean me. It's not like I've tested it or anything!)
willlarche commentedon Oct 12, 2018
Ah! Well that’s different. The fastest way for that to be solved is for you to put in a PR. Otherwise this will be triaged and prioritized for a later date.
hyochan commentedon Oct 12, 2018
@willlarche I've done the
PRfor this #22956. I needed this feature either. Thanks.willlarche commentedon Oct 12, 2018
@dooboolab , I think @lukepighetti is describing a motion issue. Should probably be in another issue.
@lukepighetti Could you write up a new issue since you understand it?
willlarche commentedon Oct 16, 2018
Ok! We have plan that we believe will satisfy our requirements:
Semanticssystem to read.""and still have room for titles.)@dooboolab , I'll add this feedback to your PR too.
@lukepighetti , please create a new ticket, if you haven't already, for the layout problems
lukepighetti commentedon Oct 16, 2018
Thanks Will, feel free to close this issue whenever you feel it is necessary
ankitchouhan commentedon Apr 8, 2019
You guys can also use this as
BottomNavigationBarItem( icon: Icon( Icons.card_giftcard, ), title: SizedBox.shrink(), )i.e set title to
And you can get rid of those titles.
Hope this helps @lukepighetti
ranggadev commentedon May 22, 2019
Great job!! :D
AtillaPehlivan commentedon Oct 2, 2019
try
showSelectedLabels: false, showUnselectedLabels: falseinstead of unused title widget@lukepighetti
github-actions commentedon Aug 15, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.