Skip to content

flutter gives low frame rates when long lists with list builder inside cards giving(avg 20-35fps) #35592

Closed
Closed
flutter gives low frame rates when long lists with list builder inside cards giving(avg 20-35fps)#35592
Labels
c: performanceRelates to speed or footprint issues (see "perf:" labels)customer: crowdAffects or could affect many people, though not necessarily a specific customer.frameworkflutter/packages/flutter repository. See also f: labels.perf: speedPerformance issues related to (mostly rendering) speedwaiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds

Description

@yersoy
yersoy
opened on Jul 4, 2019

flutter i have list view builder that builder, build items 150 times.so this is okey if i m using only list tile inside listview. but its not seems good. i m trying to use card inside that builder. card=>material=>InkWell=>ListTile

and this is gives very very low fps. im learning flutter for only perfromance . but if some one not fix this i will back ionic maybe react native.

Activity

  1. yersoy commented on Jul 4, 2019

    @yersoy
    yersoy
    on Jul 4, 2019
    Author

    list page has 34 fps and detail page 12-15 fps

  2. kafein commented on Jul 4, 2019

    @kafein
    kafein
    on Jul 4, 2019

    #22314 might be related
    Please add the output of flutter doctor -v and provide a minimal demo of the problem.

  3. InvertedX commented on Jul 10, 2019

    @InvertedX
    InvertedX
    on Jul 10, 2019

    image
    I think this issue is happening on last few builds. i tried latest v1.7.8+hotfix.3, i got the above frame rate, i tested this on a fresh project (Counter example)

    i downgraded flutter to 1.6.2, which i don't see any issues

    Details

    [✓] Flutter (Channel v1.7.8-hotfixes, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-IN)
    • Flutter version 1.7.8+hotfix.3 at /Users/sarath/flutter
    • Framework revision b712a17 (12 hours ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

    [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/sarath/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/sarath/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

    [!] Xcode - develop for iOS and macOS (Xcode 10.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2.1, Build version 10E1001
    ! CocoaPods out of date (1.6.0 is recommended).
    CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds
    to your plugin usage on the Dart side.
    Without CocoaPods, plugins will not work on iOS or macOS.
    For more info, see https://flutter.dev/platform-plugins
    To upgrade:
    brew upgrade cocoapods
    pod setup

    [✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

    [✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

    [!] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

    [✓] IntelliJ IDEA Ultimate Edition (version 2018.2.8)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 34.0.1
    • Dart plugin version 182.5215

    [✓] VS Code (version 1.36.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.2.0

    [✓] Connected device (4 available)
    • ONEPLUS A6000 • c8166160 • android-arm64 • Android 9 (API 28)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27)
    (emulator)
    • macOS • macOS • darwin-x64 • Mac OS X 10.14.5 18F132
    • web • web • web-javascript • Google Chrome 75.0.3770.100

  4. KlausJokisuo commented on Jul 12, 2019

    @KlausJokisuo
    KlausJokisuo
    on Jul 12, 2019

    I'm having exact same issue on v1.7.8+hotfix.3 build

  5. BondarenkoStas commented on Oct 1, 2019

    @BondarenkoStas
    BondarenkoStas
    on Oct 1, 2019

    @Ejdersoy how is it while using current stable v1.9.1+hotfix.2?
    Please provide a small self-contained app that demonstrates the problem. You can include small examples inline if they're enclosed by backticks, or just provide a public link to a github "gist" - https://gist.github.com/.

  6. BondarenkoStas
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    on Oct 1, 2019

  7. iapicca commented on Nov 8, 2019

    @iapicca
    iapicca
    on Nov 8, 2019

    Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!

    Thanks for your contribution.

    #31303

  8. iapicca
    closed this as completedon Nov 8, 2019

  9. yersoy commented on Dec 14, 2019

    @yersoy
    yersoy
    on Dec 14, 2019
    Author

    Ekran Alıntısı

    as you can see there is an error in every frame . and i never saw 60 fps inside my flutter app. i will gave you an example of my code but i dont know what cousing that.

  10. no-response
    removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Dec 14, 2019
  11. no-response
    reopened this on Dec 14, 2019

  12. yersoy commented on Dec 14, 2019

    @yersoy
    yersoy
    on Dec 14, 2019
    Author

    low-fps-flutter-(30-50).zip

    this is the projects assets and main.dart files just test my code you will see fps is stuttering. @iapicca

  13. yersoy commented on Dec 14, 2019

    @yersoy
    yersoy
    on Dec 14, 2019
    Author

    Ekran Alıntısı

    it is not fixed at 60 fps as seen.

    flutter doctor -v

    [√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18363.535], locale tr-TR)
    • Flutter version 1.12.13+hotfix.5 at C:\flutter\flutter
    • Framework revision 27321eb (4 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e
    • Dart version 2.7.0

    [√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\yusuf\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

    [√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 38.2.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

    [√] VS Code (version 1.41.0)
    • VS Code at C:\Users\yusuf\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.7.1

    [√] Connected device (1 available)
    • Redmi Note 7 • 83c8164 • android-arm64 • Android 9 (API 28)

    • No issues found!

  14. yersoy
    changed the title [-]flutter build apk --release gives low frame rates (avg 11fps)[/-] [+]flutter build apk --release gives low frame rates (avg 30fps)[/+] on Dec 17, 2019

  15. 8 remaining items

  16. liyuqian commented on Feb 15, 2020

    @liyuqian
    liyuqian
    on Feb 15, 2020
    Contributor

    Great. Thank you @dnfield ! Please feel free to open a separate issue dedicated to the gif problem after the validation.

  17. dnfield commented on Feb 15, 2020

    @dnfield
    dnfield
    on Feb 15, 2020
    Contributor

    Filed #50842 to help with the builds.

  18. dnfield commented on Feb 15, 2020

    @dnfield
    dnfield
    on Feb 15, 2020
    Contributor

    Not sure if we really need a separate issue or not, but can file one if you prefer.

  19. liyuqian commented on Feb 15, 2020

    @liyuqian
    liyuqian
    on Feb 15, 2020
    Contributor

    @dnfield I"m also Ok with not having a separate issue. In #50842, can you please also add a performance test that reproduces this list of cards with FadeInImage that uses gif placeholder? I think it might be a common use case worth benchmarking. It will also validate the fix's performance impact.

  20. dnfield commented on Feb 15, 2020

    @dnfield
    dnfield
    on Feb 15, 2020
    Contributor

    I would rather add the performance test separately, so that if it turns out to be flaky we can revert it separately, but adding such a test is fair.

  21. dnfield commented on Feb 15, 2020

    @dnfield
    dnfield
    on Feb 15, 2020
    Contributor

    Test in #50851

  22. dnfield
    added a commit that references this issue on Feb 15, 2020

    perf test for flutter#35592

    48609d8

  23. dnfield commented on Feb 18, 2020

    @dnfield
    dnfield
    on Feb 18, 2020
    Contributor

    @Ejdersoy - can you retry on master? The performance should be greatly improved for this now.

    @liyuqian - do we still need this bug for any BDF related tracking, or are there other bugs open for that?

  24. liyuqian commented on Feb 26, 2020

    @liyuqian
    liyuqian
    on Feb 26, 2020
    Contributor

    Created #51515 for the PhysicalShapeLayer raster cache. Will close this issue and continue our discussion there once the FadeInImage issue fix is confirmed here.

  25. liyuqian
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Feb 26, 2020

  26. kf6gpe commented on Mar 16, 2020

    @kf6gpe
    kf6gpe
    on Mar 16, 2020
    Contributor

    Believe fixed; closing.

  27. kf6gpe
    closed this as completedon Mar 16, 2020

  28. lock commented on Apr 2, 2020

    @lock
    lockbot
    on Apr 2, 2020

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  29. lock
    locked and limited conversation to collaborators on Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: performanceRelates to speed or footprint issues (see "perf:" labels)customer: crowdAffects or could affect many people, though not necessarily a specific customer.frameworkflutter/packages/flutter repository. See also f: labels.perf: speedPerformance issues related to (mostly rendering) speedwaiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions