Deflake and re-enable module_test_ios #37525

Activity

1. jmagman

   added

   a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our tests

   on Aug 2, 2019
2. jmagman

   added this to the August 2019 milestone on Aug 2, 2019
3. jmagman

   self-assigned this

   on Aug 2, 2019
4. Hixie

   modified the milestones: August 2019, OverdueThis milestone has been deleted on Sep 3, 2019
5. jmagman

   modified the milestones: OverdueThis milestone has been deleted, October 2019 on Sep 3, 2019
6. Hixie

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   on Oct 4, 2019
7. Hixie

   changed the title [-]Re-enable module_test_ios[/-] [+]Deflake and re-enable module_test_ios, module_test[/+] on Oct 23, 2019
8. Hixie commented on Oct 23, 2019

   

   Hixie

   on Oct 23, 2019

   Contributor

   More actions

   module_test was similarly turned off on mac with #43375.
9. jmagman

   modified the milestones: October 2019, GoalsThis milestone has been deleted on Nov 4, 2019
10. jmagman commented on Nov 5, 2019

    

    jmagman

    on Nov 5, 2019

    MemberAuthor

    More actions

    There seems to be some flakiness related to the pubspec modified date being in the future.

    [module_test_ios] [STDOUT] Executing: /private/tmp/flutter sdk/bin/flutter build ios --no-codesign in /var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.PCYYnC/hello
    [module_test_ios] [STDOUT] stderr: Warning: File "/private/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.PCYYnC/hello/pubspec.yaml" was created in the future. Optimizations that rely on comparing time stamps will be unreliable. Check your system clock for accuracy.
    [module_test_ios] [STDOUT] stderr: The timestamp was: 2019-11-04 15:47:32.000
    [module_test_ios] [STDOUT] stderr: The time now is: 2019-11-04 15:43:17.832054
    

    When the pubspec changes, the framework doesn't get regenerated:
    #42956
11. jmagman commented on Nov 5, 2019

    

    jmagman

    on Nov 5, 2019

    MemberAuthor

    More actions

    The fix I found for module_test_ios is purely related to the iOS path, so I split this out from turning back on the module_test. #44216
12. jmagman

    changed the title [-]Deflake and re-enable module_test_ios, module_test[/-] [+]Deflake and re-enable module_test_ios[/+] on Nov 5, 2019
13. jmagman commented on Dec 11, 2019

    

    jmagman

    on Dec 11, 2019

    MemberAuthor

    More actions

    Fixed by https://github.com/flutter/flutter/pull/45877/files.
14. jmagman

    closed this as completedon Dec 11, 2019
15. github-actions commented on Aug 13, 2021

    

    github-actionsbot

    on Aug 13, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
16. github-actions

    locked as resolved and limited conversation to collaborators on Aug 13, 2021