Skip to content

Deflake and re-enable module_test #44216

Closed

Description

@jmagman

module_test was turned off on mac with #43375.

Activity

  1. jmagman commented on Nov 5, 2019

    @jmagman
    MemberAuthor

    module_test_ios was flaking due to the pubspec being modified in the future sometimes, somehow.

    [module_test_ios] [STDOUT] Executing: /private/tmp/flutter sdk/bin/flutter build ios --no-codesign in /var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.PCYYnC/hello
    [module_test_ios] [STDOUT] stderr: Warning: File "/private/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/flutter_module_test.PCYYnC/hello/pubspec.yaml" was created in the future. Optimizations that rely on comparing time stamps will be unreliable. Check your system clock for accuracy.
    [module_test_ios] [STDOUT] stderr: The timestamp was: 2019-11-04 15:47:32.000
    [module_test_ios] [STDOUT] stderr: The time now is: 2019-11-04 15:43:17.832054
    

    That modification time difference was exposing a real bug at #42956, and fixing that bug allowed us to turn back on module_test_ios. #37525

    Could the pubspec modification time drift be exposing some bug here, too?

  2. Hixie commented on Aug 3, 2020

    @Hixie
    Contributor

    These seem to be enabled now.

  3. github-actions commented on Aug 18, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passteam-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions