Repository navigation
Gold tryjobs cannot be executed by first-time contributors #46687
Description
Pre-submit tryjobs rely on being able to decrypt the service account on Cirrus. For first time contributors, this becomes an issue when pre-submit checks attempt to run since they have not yet attained write permission to the repository. This is needed in order to decrypt the service account.
Tryjobs cannot execute without authenticating, so another solution must be implemented for this edge case.
Early ideas:
goldctl imgtest checkis a new feature from gold to check image results against baselines without authenticating.- tests will run, will need triage after merging
- Will need a way to flag a failing test as permissible so a change can land (see old implementation below) OR
- we could decide that first time contributors cannot change existing golden files on their first pull request
- The previous, manual implementation of pre-submit checks
- tests ran, needed triage after merging
- subject to breaking changes from Gold if the api changes
Activity
Piinks commentedon Jan 31, 2020
This is resolved for now for cirrus, but I think when we switch to luci it will be better. Gold doesn't need a service account to authenticate in a luci environment, which would handle this edge case much better. Currently tracking luci support for gold in #49837 and #49749. :)
github-actions commentedon Aug 23, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.