Add selectionOverlay parameter to CupertinoTimerPicker  #68509

Activity

1. sanekyy

   changed the title [-]Add to CupertinoTimerPicker selectionOverlay paramater[/-] [+]Add to CupertinoTimerPicker selectionOverlay parameter[/+] on Oct 19, 2020
2. darshankawar

   changed the title [-]Add to CupertinoTimerPicker selectionOverlay parameter[/-] [+]Add selectionOverlay parameter to CupertinoTimerPicker [/+] on Oct 20, 2020
3. darshankawar

   added

   p: cupertino_uicupertino_ui package in flutter/packagescupertino_ui package in flutter/packages

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   passed first triage

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   f: date/time pickerDate or time picker widgetsDate or time picker widgets

   on Oct 20, 2020
4. DanielEdrisian commented on Oct 30, 2020

   

   DanielEdrisian

   on Oct 30, 2020

   Contributor

   More actions

   @sanekyy Can you provide more context on this issue?
5. DanielEdrisian

   added

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Oct 30, 2020
6. sanekyy commented on Oct 30, 2020

   

   sanekyy

   on Oct 30, 2020

   Author

   More actions

   I can't provide selectionOverlay to CupertinoTimerPicker to override default value of this parameter.

   I want customize it, but I can't with current api.
7. no-response

   removed

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Oct 30, 2020
8. lecicdjuro commented on Apr 1, 2021

   

   lecicdjuro

   on Apr 1, 2021

   Last edited by lecicdjuro

   More actions

   CupertinoDatePicker doesn't have optional param for selectionOverlay Widget, so it can't be overridden or changed.
   This class should have the same option as CupertinoPicker, so we can change this overlay widget.

   @DanielEdrisian I'm using the latest stable version

   [✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.3 20D91 darwin-x64, locale en-RS)
   • Flutter version 2.0.3 at /Users/lecicdjuro/flutter
   • Framework revision 4d7946a (2 weeks ago), 2021-03-18 17:24:33 -0700
   • Engine revision 3459eb2
   • Dart version 2.12.2
9. daadu commented on May 18, 2021

   

   daadu

   on May 18, 2021

   Contributor

   More actions

   I think the right design for this would be to not add Widget selectionOverlay to either CupertinoTimePicker or CupertinoDateTimePicker, or any other "Picker".

   Instead I propose to add pickerSelectionColor to CupertinoTheme (defaulting to CupertinoColors.tertiarySystemFill), and the CupertinoPickerDefaultSelectionOverlay used underneath CupertinoPicker, defaults to CupertinoTheme.pickerSelectionColor.

   👍React with 👍1Reacted by Bohdan Honcharuk

   👀React with 👀4Reacted by Ermek Akmatov, keyurtailor44, Gufdoor and JiaheEatingOut
10. TetrixGauss commented on Jul 8, 2022

    

    TetrixGauss

    on Jul 8, 2022

    More actions

    what is going on with that update????
11. binSaed commented on Oct 6, 2022

    

    binSaed

    on Oct 6, 2022

    Contributor

    More actions

    Any update? or everything in flutter we need to rebuild from scratch!

    👍React with 👍2Reacted by Marian and Bohdan Honcharuk

    👀React with 👀2Reacted by Marian and Abdelrahman Saed
12. 6 remaining items

    Load more
13. flutter-triage-bot

    added

    triaged-designTriaged by Design Languages teamTriaged by Design Languages team

    on Jul 8, 2023
14. Hixie

    removed

    passed first triage

    on Jul 8, 2023
15. Requieem commented on Jan 25, 2024

    

    Requieem

    on Jan 25, 2024

    More actions

    Are there any updates on this? Looking at the source code it should be a rather straightforward fix, and It would be much appreciated in many Cupertino-based projects.
16. Hixie

    removed

    multiteam-retriage-candidate

    on Mar 6, 2024
17. flutter-triage-bot

    removed

    triaged-designTriaged by Design Languages teamTriaged by Design Languages team

    on Mar 30, 2024
18. flutter-triage-bot commented on Mar 30, 2024

    

    flutter-triage-botbot

    on Mar 30, 2024

    More actions

    This issue is missing a priority label. Please set a priority label when adding the triaged-design label.
19. HansMuller

    added

    P2Important issues not at the top of the work listImportant issues not at the top of the work list

    triaged-designTriaged by Design Languages teamTriaged by Design Languages team

    on Apr 3, 2024
20. HansMuller commented on Apr 3, 2024

    

    HansMuller

    on Apr 3, 2024

    Contributor

    More actions

    A fix appears to be underway - #143079
21. MitchellGoodwin commented on Jul 12, 2024

    

    MitchellGoodwin

    on Jul 12, 2024

    Contributor

    More actions

    Fixed as a part of #143079
22. MitchellGoodwin

    closed this as completedon Jul 12, 2024
23. github-actions commented on Jul 26, 2024

    

    github-actionsbot

    on Jul 26, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
24. github-actions

    locked as resolved and limited conversation to collaborators on Jul 26, 2024
25. github-project-automation

    added this to iOS Platform - Cupertino widget reviewon Aug 28, 2024
26. github-project-automation

    moved this to Engineer reviewed in iOS Platform - Cupertino widget reviewon Aug 28, 2024