Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer… by varunkamanibosc · Pull Request #143079 · flutter/flutter

varunkamanibosc · 2024-02-07T16:23:17Z

This PR is adding a new optional parameter to CupertinoDatePicker and CupertinoTimerPicker called selectionOverlayBuilder. This parameter will allow us to override the default selection overlay.

Fixing: #79559

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

…Picker

…utter into feature/79559

MitchellGoodwin

Thank you for putting this together. Sorry it took some time to get to it. Mostly LGTM with some comments.

varunkamanibosc · 2024-03-08T20:06:01Z

Thanks, @MitchellGoodwin for your feedback. I have made the changes according to the comments. Please check.

…utter into feature/79559

varunkamanibosc · 2024-04-05T19:02:18Z

Hi @MitchellGoodwin
Can you please take a look at this PR?

MitchellGoodwin

LGTM! Sorry it took so long to review.

justinmc

Mostly just a bunch of quick small stuff here, otherwise this looks good. Thanks for the PR!

Piinks · 2024-05-22T18:09:18Z

Hey @varunkamanibosc would you like to keep working on this PR and address the above feedback?

varunkamanibosc · 2024-05-23T05:18:59Z

Hi @Piinks
I am planning to work on this over this weekend

varunkamanibosc · 2024-05-25T13:00:22Z

Hi @justinmc
I made the changes as per your comments. Please review the changes.
Thanks!

justinmc

LGTM 👍

…inoTimer… (flutter/flutter#143079)

flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#143079) It's now possible to override the default selection overlay with CupertinoDatePicker.selectionOverlayBuilder and CupertinoTimerPicker.selectionOverlayBuilder.

…inoTimer… (flutter/flutter#143079)

flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from 8d36ce3 to 020aa21 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer…

63f32c8

…Picker

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages labels Feb 7, 2024

varunkamanibosc and others added 8 commits February 7, 2024 21:54

Merge branch 'master' into feature/79559

df9c4ed

Add selection overlay builder typedef docs

8e025b4

Merge branch 'feature/79559' of https://github.com/varunkamanibosc/fl…

cdff5f0

…utter into feature/79559

code formatted to fix analyzer error

a7adbc9

Merge branch 'master' into feature/79559

e68b7a2

Refactor CupertinoDatePicker tests

2f4772d

Merge branch 'feature/79559' of https://github.com/varunkamanibosc/fl…

364fd57

…utter into feature/79559

Merge branch 'master' into feature/79559

b741fff

varunkamanibosc mentioned this pull request Feb 8, 2024

Add optional param to override selectionOverlay widget for CupertinoDatePicker #79559

Closed

Merge branch 'master' into feature/79559

9f9b213

TahaTesser requested a review from MitchellGoodwin February 15, 2024 08:27

MitchellGoodwin reviewed Mar 5, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/cupertino/date_picker.dart Outdated

Comment thread packages/flutter/lib/src/cupertino/date_picker.dart Outdated

varunkamanibosc and others added 2 commits March 6, 2024 09:35

Merge branch 'master' into feature/79559

60b26f6

selectionOverlayBuilder can return null

75b0bdb

varunkamanibosc requested a review from MitchellGoodwin March 8, 2024 20:05

varunkamanibosc and others added 8 commits March 9, 2024 01:37

Merge branch 'master' into feature/79559

fe532bc

Remove unnecessary code in selectionOverlayBuilder docs

863df1a

Merge branch 'feature/79559' of https://github.com/varunkamanibosc/fl…

1cd5d62

…utter into feature/79559

Merge branch 'master' into feature/79559

94f9774

docs fixed for CupertinoDatePicker and CupertinoTimerPicker

dc10998

docs fixed

fa96ec3

Merge branch 'feature/79559' of https://github.com/varunkamanibosc/fl…

3d913cb

…utter into feature/79559

Merge branch 'master' into feature/79559

2510995

HansMuller mentioned this pull request Apr 3, 2024

Add selectionOverlay parameter to CupertinoTimerPicker #68509

Closed

MitchellGoodwin approved these changes Apr 23, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/cupertino/date_picker.dart

justinmc reviewed May 1, 2024

View reviewed changes

varunkamanibosc added 5 commits May 25, 2024 15:42

PR comments resolved and new test cases added

56b87e9

Merge branch 'master' into feature/79559

a9d0568

typo fixed

377e523

docs snippet updated

918993e

docs snippet fixed

0c5832f

varunkamanibosc requested a review from justinmc May 25, 2024 12:59

justinmc approved these changes May 28, 2024

View reviewed changes

justinmc merged commit e2e68c0 into flutter:master May 28, 2024

engine-flutter-autoroll mentioned this pull request May 29, 2024

Roll Flutter from a1a33e63b911 to 60d32e45346e (19 revisions) flutter/packages#6828

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024

e2e68c0 Add selectionOverlayBuilder in CupertinoDatePicker and Cupert…

2b5cc6e

…inoTimer… (flutter/flutter#143079)

engine-flutter-autoroll mentioned this pull request May 29, 2024

Roll Flutter from a1a33e63b911 to c85fa6abf4ff (20 revisions) flutter/packages#6829

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024

e2e68c0 Add selectionOverlayBuilder in CupertinoDatePicker and Cupert…

9c09395

…inoTimer… (flutter/flutter#143079)

Piinks mentioned this pull request May 31, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

e2e68c0 Add selectionOverlayBuilder in CupertinoDatePicker and Cupert…

594b1bc

…inoTimer… (flutter/flutter#143079)

Conversation

varunkamanibosc commented Feb 7, 2024

Pre-launch Checklist

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

varunkamanibosc commented Mar 8, 2024

Uh oh!

varunkamanibosc commented Apr 5, 2024

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented May 22, 2024

Uh oh!

varunkamanibosc commented May 23, 2024

Uh oh!

varunkamanibosc commented May 25, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants