Skip to content

Add tests for animated_switcher.0.dart API example. - #149180

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
ksokolovskyi:add-animated-switcher-example-tests
May 29, 2024
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
ksokolovskyi:add-animated-switcher-example-tests

Conversation

@ksokolovskyi

Copy link
Copy Markdown
Contributor

This PR contributes to #130459

Description

  • Adds tests for examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 28, 2024
@goderbauer
goderbauer requested review from TahaTesser and bleroux May 28, 2024 22:07
Comment thread examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart Outdated
Comment thread examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart Outdated
@ksokolovskyi
ksokolovskyi requested a review from TahaTesser May 29, 2024 08:34
Comment thread examples/api/test/widgets/animated_switcher/animated_switcher.0_test.dart Outdated
@ksokolovskyi
ksokolovskyi requested a review from TahaTesser May 29, 2024 09:54
Comment thread examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart Outdated
Comment thread examples/api/test/widgets/animated_switcher/animated_switcher.0_test.dart Outdated
@ksokolovskyi
ksokolovskyi requested a review from TahaTesser May 29, 2024 10:17

@TahaTesser TahaTesser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux bleroux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@auto-submit
auto-submit Bot merged commit 60d32e4 into flutter:master May 29, 2024
@ksokolovskyi

Copy link
Copy Markdown
Contributor Author

@TahaTesser @bleroux thanks for the review!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 29, 2024
flutter/flutter@a1a33e6...c85fa6a

2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223)
2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180)
2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220)
2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568)
2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224)
2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470)
2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767)
2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207)
2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594)
2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062)
2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199)
2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198)
2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161)
2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079)
2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006)
2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042)
2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184)
2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169)
2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150)
2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
This PR contributes to flutter#130459

### Description
- Adds tests for `examples/api/lib/widgets/animated_switcher/animated_switcher.0.dart`
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@a1a33e6...c85fa6a

2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223)
2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180)
2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220)
2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568)
2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224)
2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470)
2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767)
2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207)
2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594)
2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062)
2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199)
2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198)
2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161)
2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079)
2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006)
2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042)
2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184)
2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169)
2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150)
2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@a1a33e6...c85fa6a

2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223)
2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180)
2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220)
2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568)
2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224)
2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470)
2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767)
2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207)
2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594)
2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062)
2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199)
2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198)
2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161)
2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079)
2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006)
2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042)
2024-05-28 [email protected] Roll Packages from 8d36ce3 to 020aa21 (1 revision) (flutter/flutter#149184)
2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169)
2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150)
2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants