Repository navigation
Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" - #149224
Merged
auto-submit[bot] merged 1 commit intoMay 29, 2024
Merged
Conversation
![auto-submit[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This reverts commit af5a1a9.
auto-submit
Bot
added
the
revert of
github-actions
Bot
added
framework
fluttergithubbot
approved these changes
May 29, 2024
auto-submit
Bot
deleted the
revert_af5a1a9e117933b0254a256019a7bbc62d28f9fd
branch
May 29, 2024 02:33
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 29, 2024
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 29, 2024
flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer� (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…" (flutter#149224) Reverts: flutter#148470 Initiated by: eyebrowsoffire Reason for reverting: Unit test failures closing the tree. Original PR Author: hello-coder-xu Reviewed By: {QuncCccccc, Piinks} This change reverts the following previous change: * sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use * Fixes flutter#138871
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer� (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer� (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from 8d36ce3 to 020aa21 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #148470
Initiated by: eyebrowsoffire
Reason for reverting: Unit test failures closing the tree.
Original PR Author: hello-coder-xu
Reviewed By: {QuncCccccc, Piinks}
This change reverts the following previous change:
Fixes #138871
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.