Skip to content

Add optional param to override selectionOverlay widget for CupertinoDatePicker #79559

Closed
Closed
Add optional param to override selectionOverlay widget for CupertinoDatePicker#79559
Labels
c: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterf: date/time pickerDate or time picker widgetsframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Description

@lecicdjuro
lecicdjuro
opened on Apr 1, 2021

CupertinoDatePicker doesn't have optional param for selectionOverlay Widget, so it can't be overridden or changed.
This class should have the same option as CupertinoPicker, so we can change this overlay widget.

@DanielEdrisian I'm using the latest stable version

[✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.3 20D91 darwin-x64, locale en-RS)
• Flutter version 2.0.3 at /Users/lecicdjuro/flutter
• Framework revision 4d7946a (2 weeks ago), 2021-03-18 17:24:33 -0700
• Engine revision 3459eb2
• Dart version 2.12.2

Activity

  1. TahaTesser
    added
    in triagePresently being triaged by the triage team
    p: cupertino_uicupertino_ui package in flutter/packages
    frameworkflutter/packages/flutter repository. See also f: labels.
    passed first triage
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Apr 5, 2021

  2. TahaTesser commented on Apr 5, 2021

    @TahaTesser
    TahaTesser
    on Apr 5, 2021
    Contributor

    Related #68509

  3. TahaTesser
    added
    f: date/time pickerDate or time picker widgets
    on Apr 5, 2021
  4. darshankawar
    added
    c: new featureNothing broken; request for a new capability
    on Jan 21, 2022
  5. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-designOwned by Design Languages team
    triaged-designTriaged by Design Languages team
    on Jul 8, 2023
  6. Hixie
    removed
    passed first triage
    on Jul 8, 2023

  7. Jaaco commented on Oct 11, 2023

    @Jaaco
    Jaaco
    on Oct 11, 2023

    Any updates on when this will be added?

  8. TahaTesser commented on Oct 11, 2023

    @TahaTesser
    TahaTesser
    on Oct 11, 2023
    Contributor

    Any updates on when this will be added?

    PRs are welcome, feel free to create one. Happy to review.

  9. varunkamanibosc commented on Feb 6, 2024

    @varunkamanibosc
    varunkamanibosc
    on Feb 6, 2024
    Contributor

    Hi @TahaTesser I would like to work on this feature. Can you please guide me?

  10. varunkamanibosc commented on Feb 7, 2024

    @varunkamanibosc
    varunkamanibosc
    on Feb 7, 2024
    Contributor

    @TahaTesser I went through the code. Here are my observations.

    We have 3 columns. Each column has its own overlay. We have 3 constants. _startSelectionOverlay, _centerSelectionOverlay, _endSelectionOverlay. All 3 overlays are using CupertinoPickerDefaultSelectionOverlay. We are managing the border radius for each overlay.

    For this new functionality, Should I add 3 new properties called: startSelectionOverlay, centerSelectionOverlay, endSelectionOverlayto theCupertinoDatePicker?

  11. varunkamanibosc commented on Feb 8, 2024

    @varunkamanibosc
    varunkamanibosc
    on Feb 8, 2024
    Contributor

    @TahaTesser I have opened a PR #143079. Can you please take a look?

  12. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024

  13. victorsanni commented on Aug 23, 2024

    @victorsanni
    victorsanni
    on Aug 23, 2024
    Contributor

    This should be fixed by #143079.

  14. victorsanni
    closed this as completedon Aug 23, 2024
  15. victorsanni
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Aug 23, 2024

  16. github-actions commented on Sep 6, 2024

    @github-actions
    github-actionsbot
    on Sep 6, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  17. github-actions
    locked as resolved and limited conversation to collaborators on Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterf: date/time pickerDate or time picker widgetsframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions