Repository navigation
Use ARM macOS frameworks, gen_snapshot_x64 and gen_snapshot_arm64 in the tool #97681
Description
From #60113 (comment)
Following #97671 and https://flutter-review.googlesource.com/c/recipes/+/26040,
FlutterMacOS.frameworkcontains the lipo'd x64 and arm64 engine dylib, and two newgen_snapshotbinaries are included with the engine artifacts as follows:
bin/cache/artifacts/engine/darwin-x64/gen_snapshot_x64bin/cache/artifacts/engine/darwin-x64/gen_snapshot_arm64bin/cache/artifacts/engine/darwin-x64-profile/gen_snapshot_x64bin/cache/artifacts/engine/darwin-x64-profile/gen_snapshot_arm64bin/cache/artifacts/engine/darwin-x64-release/gen_snapshot_x64bin/cache/artifacts/engine/darwin-x64-release/gen_snapshot_arm64The tool should switch to using those
gen_snapshots, and then we can remove thegen_snapshotthat's still there that doesn't have a suffix that specifies the architecture.
Additionally, remove arm64 EXCLUDED_ARCHS (see #72748) so the apps actually start getting built natively.
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
jmagman commentedon Feb 11, 2022
More thoughts:
Backend script hardcodes the arch
flutter/packages/flutter_tools/bin/macos_assemble.sh
Line 73 in fa0782b
should look more like
flutter/packages/flutter_tools/bin/xcode_backend.dart
Line 418 in 5f3bee5
Here's the local-engine single-arch build setting code for iOS
flutter/packages/flutter_tools/lib/src/ios/xcode_build_settings.dart
Lines 188 to 189 in 9e88fe3
If plugins are only built with x86 slices this will also be a problem as it was adopting arm64 iOS simulators #85713
knopp commentedon Feb 11, 2022
Are there any binary-only plugins? Cocoa-pods plugin shouldn't really care about target architecture, should it?
knopp commentedon Feb 11, 2022
Also eventually we'd want to get lipo'd gen_snapshots as well.
zanderso commentedon Feb 11, 2022
It might make sense to lipo
gen_snapshot_arm64, but Dart currently does not support generating x64 code on an arm64 host.jmagman commentedon Feb 11, 2022
Yes, you can bundle binaries. That's what happened with
google_sign_inandgoogle_maps_flutter, they depend on pre-built SDKs which didn't contain ARM.https://github.com/CocoaPods/Specs/blob/f052cc63fbbae6566e0998fde5b16decd90d8ef9/Specs/a/d/d/GoogleMaps/5.1.0/GoogleMaps.podspec.json#L350-L352
https://guides.cocoapods.org/syntax/podspec.html#vendored_frameworks
jmagman commentedon Feb 18, 2022
Also need to revert #92508
cbracken commentedon Mar 17, 2022
Fixed by #100271.
github-actions commentedon Mar 31, 2022
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.