Skip to content

Mac web_tool_tests failing on some machines with malformed cached chrome cipd package #99372

Closed

Description

@jmagman

As part of upgrading the Chrome package in #98278, a Chromium cipd package G-lZgp8TuOPH0ndPr62HLAzRTWcFV3RRvFjOYyPZq_4C was uploaded that was malformed somehow that flutter couldn't detect the browser as a valid device. A new one was uploaded today that tests passed with.

The engine roll #99362 failed on a Mac web_tool_tests with a cache hit with the malformed package:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20web_tool_tests/12828/overview

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8820852491161740497/+/u/Chrome_and_driver_dependency/ensure_installed/stdout

[P19159 15:21:32.857 action_plan.go:160 I] In root:
[P19159 15:21:32.857 action_plan.go:172 I]   to update:
[P19159 15:21:32.857 action_plan.go:174 I]     flutter_internal/browsers/chrome/mac-amd64 (Qe3INUxKmaLOB1bDUu7ZD8otihLlr3k4mFVuFq8R97kC -> G-lZgp8TuOPH0ndPr62HLAzRTWcFV3RRvFjOYyPZq_4C)
[P19159 15:21:32.857 instancecache.go:187 I] Using instance cache at /opt/s/cipd_cache/cache/instances
[P19159 15:21:32.858 instancecache.go:409 I] [fetch] Cache hit for flutter_internal/browsers/chrome/mac-amd64:G-lZgp8TuOPH0ndPr62HLAzRTWcFV3RRvFjOYyPZq_4C
[P19159 15:21:32.860 deployer.go:294 I] [unzip] Deploying flutter_internal/browsers/chrome/mac-amd64:G-lZgp8TuOPH0ndPr62HLAzRTWcFV3RRvFjOYyPZq_4C into /opt/s/w/ir/cache/chrome/chrome(/)

Malformed:
https://chrome-infra-packages.appspot.com/p/flutter_internal/browsers/chrome/mac-amd64/+/G-lZgp8TuOPH0ndPr62HLAzRTWcFV3RRvFjOYyPZq_4C

Correct:
https://chrome-infra-packages.appspot.com/p/flutter_internal/browsers/chrome/mac-amd64/+/BlBCql9ZngKYkn_tiqUUCnZKtZtbbCnsP0RgmLIn2ZwC

Does build843-m9 need its chrome cache cleared? Do any other builders have the wrong one cached?

Here's one that's passing that used BlBCql9ZngKYkn_tiqUUCnZKtZtbbCnsP0RgmLIn2ZwC https://ci.chromium.org/p/flutter/builders/prod/Mac%20web_tool_tests/5090?

Activity

  1. godofredoc commented on Mar 2, 2022

    @godofredoc
    Contributor

    This is strange, cipd talks to the server to resolve the hash for the tag and then downloads it or reuse the one from the cache with the correct hash.

  2. godofredoc commented on Mar 2, 2022

    @godofredoc
    Contributor

    Could it be that it was scheduled before the new cipd package was available? 15:21:07 Tue, Mar 01 2022 PST

  3. jmagman commented on Mar 2, 2022

    @jmagman
    MemberAuthor

    Wonder how it got version 98 then since you merged that after the cipd package was fixed.
    Feel free to close if this is no longer an issue.

  4. godofredoc commented on Mar 2, 2022

    @godofredoc
    Contributor

    yeah, just checked and I landed the cipd package update at 1:00:00 PM PST

  5. zanderso commented on Mar 2, 2022

    @zanderso
    Member

    /sub

  6. godofredoc commented on Mar 2, 2022

    @godofredoc
    Contributor

    @CaseyHillers is this bug on your radar?

  7. CaseyHillers commented on Mar 2, 2022

    @CaseyHillers
    Contributor

    This sounds like a common issue occurring in the mac bots. I'm going to do a cleanup of impacted bots, but do tell me if it's a larger impact.

    Related issue: #99429

  8. CaseyHillers commented on Mar 3, 2022

    @CaseyHillers
    Contributor

    As FYI, my corp machines lacks permissions to access our mac minis. I'm debugging the cert issues, but no progress.

    If there's no updates, I'll reach out to the chrome labs team to get help tomorrow morning.

  9. godofredoc commented on Mar 3, 2022

    @godofredoc
    Contributor

    Cleaned the caches of all the machines with failures.

  10. self-assigned this
    on Mar 3, 2022
  11. CaseyHillers commented on Mar 3, 2022

    @CaseyHillers
    Contributor

    Based on https://ci.chromium.org/p/flutter/builders/try/Mac%20web_tool_tests - This is having a large impact on our fleet with an 80% failure rate

  12. godofredoc commented on Mar 3, 2022

    @godofredoc
    Contributor

    Let's add another tag version:98.1 to the cipd package and update the references. Turns out that deleting tags is a bad idea as they are locally cached by cipd.

  13. CaseyHillers commented on Mar 4, 2022

    @CaseyHillers
    Contributor

    Closing as this seems fixed with the revving chrome.

    PRs in https://ci.chromium.org/p/flutter/builders/try/Mac%20web_tool_tests are passing if they're rebased with the latest changes. Please re-open if this is still occurring on new PRs

  14. CaseyHillers commented on Mar 7, 2022

    @CaseyHillers
    Contributor

    We should manually wipe the cipd caches of these bots

  15. removed their assignment
    on Mar 7, 2022
  16. godofredoc commented on Mar 18, 2022

    @godofredoc
    Contributor

    Turns out this was caused by web_engine and adhoc tests using an incorrect version of the xcode module. It was fixed here: https://flutter-review.googlesource.com/c/recipes/+/28064

  17. github-actions commented on Apr 1, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  18. locked as resolved and limited conversation to collaborators on Apr 1, 2022
  19. moved this from Verified to To be archived in [DEPRECATED] Infra Ticket Queueon Jun 26, 2023
  20. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressionteam-infraOwned by Infrastructure team

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions