Repository navigation
Reset missing deprecation for ScrollbarThemeData.copyWith(showTrackOnHover) - #111706
Merged
Merged
Conversation
Piinks
added
c: contributor-productivity
flutter-dashboard
Bot
added
the
p: material_ui
xu-baolin
reviewed
Sep 16, 2022
| // Changes made in https://github.com/flutter/flutter/pull/111706 | ||
| Scrollbar scrollbar = Scrollbar(trackVisibility: true); | ||
| bool nowShowing = scrollbar.trackVisibility; | ||
| ScrollbarThemeData scrollbarTheme = ScrollbarThemeData(trackVisibility: nowShowing); |
Member
There was a problem hiding this comment.
trackVisibility in ScrollbarThemeData is type of MaterialStateProperty<bool?>?, can this fix works well?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's not a 100% fix, but we did the same transformation for isAlwaysShown ➡️ thumbVisibility.
In general, if we can point folks in the right direction, I think it's helpful. :)
This was referenced Sep 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 17, 2022
7 of 8 tasks
This was referenced Feb 20, 2024
chunhtai
pushed a commit
to chunhtai/packages
that referenced
this pull request
Jun 12, 2026
…180) This PR is to remove deprecated `Scrollbar.showTrackOnHover` and `ScrollbarThemeData.showTrackOnHover`. These parameters are made obsolete in flutter/flutter#111706. Part of flutter/flutter#143956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while completing an audit for the next batch of deprecations to be removed from the framework.
Scrollbar and ScrollbarThemeData showTrackOnHover is deprecated, but the later .copyWith was not notated for it. This adds the deprecation notation and resets the clock for the bunch.
It also adds a dart fix for this deprecation.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.