Skip to content

Remove showTrackOnHover from Scrollbar and ScrollbarTheme - #144180

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
QuncCccccc:remove_show_track_on_hover
Mar 13, 2024
Merged

Remove showTrackOnHover from Scrollbar and ScrollbarTheme#144180
auto-submit[bot] merged 6 commits into
flutter:masterfrom
QuncCccccc:remove_show_track_on_hover

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is to remove deprecated Scrollbar.showTrackOnHover and ScrollbarThemeData.showTrackOnHover.

These parameters are made obsolete in #111706.
Part of #143956

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: scrolling Viewports, list views, slivers, etc. labels Feb 26, 2024
@QuncCccccc

QuncCccccc commented Mar 6, 2024

Copy link
Copy Markdown
Contributor Author

This one is ready to review but might need to merge the super editor one first to fix the customer testing:)

@QuncCccccc
QuncCccccc marked this pull request as ready for review March 6, 2024 20:42
@QuncCccccc
QuncCccccc requested a review from Piinks March 6, 2024 20:42
Piinks
Piinks approved these changes Mar 6, 2024
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yes, super editor will need to migrate first before this can land. 👍

@QuncCccccc QuncCccccc mentioned this pull request Mar 8, 2024
Merged
@QuncCccccc
QuncCccccc force-pushed the remove_show_track_on_hover branch 2 times, most recently from fccd4fc to 6727343 Compare March 9, 2024 01:22
@QuncCccccc QuncCccccc mentioned this pull request Mar 9, 2024
Merged
8 tasks done
auto-submit Bot pushed a commit to flutter/tests that referenced this pull request Mar 11, 2024
@QuncCccccc
Update super editor hash to the latest commit (#351)
9908aaf 
This PR is to update super editor tests to the latest commit with the fix related to flutter/flutter#144180.
@QuncCccccc
QuncCccccc force-pushed the remove_show_track_on_hover branch 2 times, most recently from 34a1682 to a9ebf04 Compare March 12, 2024 17:02
@QuncCccccc
QuncCccccc force-pushed the remove_show_track_on_hover branch from 2c4f3bd to 227e6c0 Compare March 13, 2024 07:21
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2024
@auto-submit
auto-submit Bot merged commit 1ccad1a into flutter:master Mar 13, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
9d04675 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
2ae86ab 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
3ab1147 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
0dac525 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
6dea41b 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
0e737ef 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
e56a0c7 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
dd6a6c2 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
5d96adc 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
e70c827 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
3ba7a80 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
ba0e4bd 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
d6fd5a6 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
e1a4df6 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
64b816c 
…e` (flutter/flutter#144180)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
b1cfb0a 
…e` (flutter/flutter#144180)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
b3aa877 
…e` (flutter/flutter#144180)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
f05f212 
…e` (flutter/flutter#144180)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
5bdbaa3 
…e` (flutter/flutter#144180)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
1ccad1a Remove showTrackOnHover from Scrollbar and `ScrollbarThem…
a41ba67 
…e` (flutter/flutter#144180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @Piinks