Skip to content

[flutter_test] Adds method to mock EventChannels - #123726

Merged
auto-submit[bot] merged 32 commits into
flutter:masterfrom
Rexios80:mock-event-channel
Apr 7, 2023
Merged

[flutter_test] Adds method to mock EventChannels#123726
auto-submit[bot] merged 32 commits into
flutter:masterfrom
Rexios80:mock-event-channel

Conversation

@Rexios80

@Rexios80 Rexios80 commented Mar 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Currently there is a way to mock MethodChannels, but no built in way to easily mock EventChannels. This PR adds a setMockStreamHandler method to go along with the existing setMockMethodCallHandler

#26528
#38954

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 29, 2023
@Rexios80
Rexios80 marked this pull request as ready for review March 29, 2023 23:05
goderbauer
goderbauer reviewed Mar 31, 2023
View reviewed changes
Comment thread packages/flutter_test/lib/src/mock_event_channel.dart Outdated
goderbauer
goderbauer reviewed Mar 31, 2023
View reviewed changes
Comment thread packages/flutter_test/lib/src/mock_event_channel.dart Outdated
@pdblasi-google
pdblasi-google self-requested a review March 31, 2023 21:41
pdblasi-google
pdblasi-google reviewed Mar 31, 2023
View reviewed changes

@pdblasi-google pdblasi-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you've got here, it cleans things up quite a lot! Just a couple of nits and an API suggestion that I think will improve discoverability.

Comment thread packages/flutter_test/lib/src/test_default_binary_messenger.dart Outdated
Comment thread packages/flutter_test/lib/src/test_default_binary_messenger.dart Outdated
Comment thread packages/flutter_test/lib/src/mock_event_channel.dart
Comment thread packages/flutter_test/lib/src/mock_event_channel.dart Outdated
pdblasi-google
pdblasi-google reviewed Apr 4, 2023
View reviewed changes
Comment thread packages/flutter_test/lib/src/mock_event_channel.dart Outdated
@Rexios80

Rexios80 commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

@pdblasi-google Should I just keep merging main into this until the Google Testing passes?

@pdblasi-google

pdblasi-google commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

@Rexios80

If this one doesn't work, I'll escalate internally. I've been following a thread on the issues and I think they have been resolved. If you'd like, I have access to the "Update branch" button, so I can follow through on this one 'til it's able to get merged.

@goderbauer

goderbauer commented Apr 6, 2023

Copy link
Copy Markdown
Member

The issue should be resolved and Google testing is working again. May require another rebase to trigger it again, though.

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit

auto-submit Bot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 123726, due to This PR has not met approval requirements for merging. You have project association NONE and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submit Bot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 123726, due to Validations Fail.

goderbauer
goderbauer reviewed Apr 6, 2023
View reviewed changes
Comment thread packages/flutter_test/lib/src/test_default_binary_messenger.dart Outdated
Comment thread packages/flutter_test/lib/src/test_default_binary_messenger.dart Outdated
Comment thread packages/flutter_test/lib/src/mock_event_channel.dart Outdated
Comment thread packages/flutter_test/lib/src/test_default_binary_messenger.dart
@Rexios80
Rexios80 requested a review from goderbauer April 7, 2023 01:00
goderbauer
goderbauer approved these changes Apr 7, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2023
@auto-submit
auto-submit Bot merged commit f28eb28 into flutter:master Apr 7, 2023
zanderso added a commit that referenced this pull request Apr 7, 2023
@zanderso
Revert "[flutter_test] Adds method to mock EventChannels (#123726)"
eda8743 
This reverts commit f28eb28.
@zanderso zanderso mentioned this pull request Apr 7, 2023
Merged
zanderso added a commit that referenced this pull request Apr 7, 2023
@zanderso
Revert "[flutter_test] Adds method to mock EventChannels" (#124401)
2f4a6af 
Reverts #123726

Analysis failures on CI
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/12890/overview
@Rexios80 Rexios80 mentioned this pull request Apr 7, 2023
Merged
@HansMuller HansMuller mentioned this pull request Apr 7, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2023
@engine-flutter-autoroll
f28eb28 [flutter_test] Adds method to mock EventChannels (flutter/flu…
4c21c8a 
…tter#123726)
@Rexios80

Rexios80 commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

In case anyone wants to use this code before it's released to stable, I copied this code into the mock_event_channel package. When this PR is released to stable, just remove that package.

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@Rexios80 @exaby73
[flutter_test] Adds method to mock EventChannels (flutter#123726)
0aa178d 
[flutter_test] Adds method to mock EventChannels
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@zanderso @exaby73
Revert "[flutter_test] Adds method to mock EventChannels" (flutter#12…
e78290a 
…4401)

Reverts flutter#123726

Analysis failures on CI
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/12890/overview
@danagbemava-nc danagbemava-nc mentioned this pull request Jul 28, 2023
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes
+1 more reviewer
@pdblasi-google pdblasi-google pdblasi-google approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rexios80 @pdblasi-google @goderbauer